Learn-to-send-email-via-google-script-html-no-server: Inconsistency in README for thankyou_message

Created on 28 Dec 2018  ยท  2Comments  ยท  Source: dwyl/learn-to-send-email-via-google-script-html-no-server

Great resource, thanks for all the effort!

There's a inconsistency in the README causing the thankyou_message not to display. Might be confusing for some people.

The README says to use an id:

image

But in form-submission-handler.js it references the class:

          var thankYouMessage = form.querySelector(".thankyou_message");
          if (thankYouMessage) {
            thankYouMessage.style.display = "block";
          }

Solution is to update either the README (<div style="display:none;" class="thankyou_message">) or the javascript (form.querySelector("#thankyou_message");).

bug help wanted starter

Most helpful comment

Sure thing! I also updated the text around it a bit hopefully to make it a bit more clear to new users. Let me know if you want something changed.

All 2 comments

Hi @timvink, ๐Ÿ˜Š
good observation. ๐Ÿ”โœ…
That is indeed an inconsistency. ๐Ÿ˜ž
If you have time to update it, we would _welcome_ a pull request. ๐Ÿ‘
Thank you! โ˜€๏ธ

Sure thing! I also updated the text around it a bit hopefully to make it a bit more clear to new users. Let me know if you want something changed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ryanlao picture ryanlao  ยท  3Comments

EugeneFitzher picture EugeneFitzher  ยท  4Comments

mckennapsean picture mckennapsean  ยท  4Comments

ThomasSalty picture ThomasSalty  ยท  4Comments

sidbatra picture sidbatra  ยท  4Comments