Leakcanary: Using FailTestOnLeakRunListener fails to report back failures when using Android Test Orchestrator.

Created on 30 Jun 2018  路  7Comments  路  Source: square/leakcanary

When using LeakCanary with Android Test Orchestrator and FailTestOnLeakRunListener, the RunListener fails to report the failure back to the Test Orchestrator even though it finds the leak.

Here's a sample. Run TuPeuxPasTest:
https://github.com/runningcode/leakcanary/tree/no/test-orchestrator

This is actually a bug with Android Test Orchestrator, here is a sample repro:
https://github.com/runningcode/TestOrchBug

And filed this bug with android: https://issuetracker.google.com/issues/110978490~~
Reopened here: https://issuetracker.google.com/issues/154639612

help wanted
Source
picture runningcode
👍1

All 7 comments

We should look at how failure reporting is implemented in the orchestrator.

pyricau picture pyricau on 4 Jul 2018

Looks like orchestrator is just an APK: https://dl.google.com/dl/android/maven2/com/android/support/test/orchestrator/1.0.2/orchestrator-1.0.2.pom

The pom.xml has a dependency on com.android.support.test.services:test-services

https://dl.google.com/dl/android/maven2/com/android/support/test/services/test-services/1.0.2/test-services-1.0.2.pom

Which is also an APK and has no dependency.

pyricau picture pyricau on 20 Jul 2018

We'll ship 1.6 as is for now, with the known issue that it doesn't work with the Android Test orchestrator, until we figure out exactly works / how it differs.

pyricau picture pyricau on 21 Jul 2018

AndroidTestOrchestrator runs every test in a separate test runner. So that a FailTestOnLeakRunListener will be created for each test. I created a feature request (https://issuetracker.google.com/issues/110768520) to add one time callbacks to AndroidTestOrchestrator to notify test run start/stop. Maybe it would help this scenario as well.

balachandarlinks picture balachandarlinks on 9 Aug 2018

Refiled the bug since the original was closed. Please star the issue here: https://issuetracker.google.com/issues/154639612

runningcode picture runningcode on 22 Apr 2020
👍1

btw I started some exploration here: #1758

pyricau picture pyricau on 24 Apr 2020

Finally got something ready! https://github.com/square/leakcanary/pull/1849

pyricau picture pyricau on 4 Jun 2020
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

edgelv34 picture edgelv34  路  7Comments
hidroh picture hidroh  路  3Comments
divyenduz picture divyenduz  路  6Comments
smallgirl picture smallgirl  路  3Comments
basti-shi031 picture basti-shi031  路  3Comments