Leaflet: L.Circle: circles with same radius have different sizes with L.CRS.Simple

[giacomoburattini]

How to reproduce

• Leaflet version: 1.2.0
• Draw circles on the map (Please take a look at the JSFiddle: https://jsfiddle.net/wL9zgz1n/5/

Circles have different sizes even if they have the same radius

After a quick look at the code it seems that the problem is the rounding applied by the latLngToLayerPoint function here https://github.com/Leaflet/Leaflet/blob/703ae02aa8cbd0b87be5b01e77754b83ad732267/src/layer/vector/Circle.js#L97 which produces different radius values depending on the circle coordinates.

[danydev]

seems to be the same issue described here https://github.com/Leaflet/Leaflet/issues/4582

[perliedman]

@danydev well spotted, I'm closing as duplicate of #4582.

[danydev]

After deeper inspection, I'm not sure it's the same exact issue. By looking at the pull request in #4582 I see that the fix is in the code branch for L.CRS.Earth.distance while this bug refers to the L.CRS.Simple, so even if we finalize the proposed fix, we'll not fix this one.
It may be helpful to leave this case open to have feedback for an eventual fix.

[giacomoburattini]

This issue refers to L.CRS.Simple so the fix proposed in #4582 won't fix this one.

[perliedman]

Ok, lets instead say this is then a duplicate of #4745 and fixed by #4808, which removes the rounding in latLngToLayerPoint :smile:.