Ldaprecord-laravel: Errors with /vendor/directorytree/ldaprecord-laravel/src/Hydrators/PasswordHydrator.php

[stephenucr]

Describe the bug
I am trying to configure without the use of password syncing.

I get the following error:
Too few arguments to function IlluminateDatabaseEloquentModel::setAttribute(), 1 passed in /srv/sites/dev/steve/projects/doav3/site/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php on line 675 and exactly 2 expected

This is resulting from lines 43 - 51 of the PasswordHydrator.php file
protected function setPassword(EloquentModel $model, $password)
{
// If the model has a mutator for the password field, we
// can assume hashing passwords is taken care of.
// Otherwise, we will hash it normally.
$password = $model->hasSetMutator($this->passwordColumn()) ? $password : Hash::make($password);

    $model->setAttribute($this->passwordColumn(), $password);
}

My config is here :

'providers' => [
    'users' => [
        'driver' => 'eloquent',
        'model' => App\User::class,
    ],
    'ldap' => [
        'driver' => 'ldap',
        'model' => LdapRecord\Models\ActiveDirectory\User::class,
        'rules' => [],
        'database' => [
            'model' => App\User::class,
            'password_column' => null,
            'sync_passwords' => false,
            'sync_attributes' => [
                'name' => 'cn',
                'username' => 'samaccountname',
                'email' => 'mail',
            ],
        ],
    ],

If I comment out those lines of code in the PasswordHydrator.php file, it works fine .. but I am not comfortable with that option going forward.

Love the library by the way.

Environment (please complete the following information):

• LDAP Server Type: ActiveDirectory
• PHP Version: 7.2.17
• Laravel Version: 7.6.1

[stevebauman]

Hi @stephenucr,

Thanks for your kind words! I’m glad you like LdapRecord 😄

To resolve your issue, set password_column to false instead of null.

I may have documented this incorrectly, let me make sure it’s correct.

Give the above a shot and let me know if it works!

[stephenucr]

OMG .. Awesome! Thanks so much, that worked.

[stevebauman]

Yup I documented this incorrectly:

https://ldaprecord.com/docs/laravel/auth/configuration/#database-password-column

You can also set the value to null if your database table does not have any password column at all:

Fixing now 😄

[stevebauman]

Glad you're up and running @stephenucr! Also just fixed this in the docs -- it's now live. Thanks!

[stephenucr]

thanks for the quick response !

[stevebauman]

No worries! Please feel free to drop another issue if you have any further questions or need assistance. 👍