Layer5: [Event] KubeCon EU: Multiple speakers hyperlinked to same member profile

Created on 5 Apr 2021  路  22Comments  路  Source: layer5io/layer5

Description
The hyperlink to speakers on this event is broken in that it points to two people on the same member profile. Member profiles are individually hosted.

Ken does not have a profile.
Lee has a profile.

Expected Behavior
Either no hyperlink at all or only Lee's name hyperlinked.

Screenshots
Screen Shot 2021-04-05 at 2 48 25 PM


Contributor Resources

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

areevents frameworgatsby good first issue help wanted kinbug

Most helpful comment

Yess Sure @leecalcote 馃殌
@SachiniAbeygunawardhana Lmk if you have any issues, I would love to help you out 馃

All 22 comments

@adithyaakrishna fyi

Hi, I'm new to Open Source Contributions. Shall I work on this issue?

@adithyaakrishna fyi
@leecalcote Will fix this ASAP 馃樁

@leecalcote Can the page be like this?
https://layer5.io/community/events/kubecon-eu-2020
It does not have any speaker and some other events are also the same 馃樁

@adithyaakrishna its fine as not all of these individual pages are referenced.

Hi, I'm new to Open Source Contributions. Shall I work on this issue?

@SachiniAbeygunawardhana I think @adithyaakrishna is already working on this. Take a look at the others issues. A lot more of them to be tackled :)

Wait, @adithyaakrishna. @SachiniAbeygunawardhana inquired first. Given that @SachiniAbeygunawardhana is new to open source, let鈥檚 be good stewards and ensure @SachiniAbeygunawardhana has a great first experience.

@SachiniAbeygunawardhana, please do take this issue forward. @adithyaakrishna is here to answer any questions that you might have - any at all. Please join the Layer5 community Slack if chatting is helpful. @adithyaakrishna will get on a call with you if that helps. I know that he won鈥檛 rest until you鈥檝e been successful here. 馃槃

Yess Sure @leecalcote 馃殌
@SachiniAbeygunawardhana Lmk if you have any issues, I would love to help you out 馃

@leecalcote, @adithyaakrishna Thanks a lot for assigning this to me. @adithyaakrishna Please excuse me if you had already started working on this. I will contact you if I need any help.

The page looks like this after doing some minor changes.
image
The hyperlink is removed. I tried to add the hyperlink only to the second speaker, but could not succeed yet.
Could you please tell me whether the above solution is acceptable?

Nice progress, @SachiniAbeygunawardhana 馃憤 I'll let @adithyaakrishna help identify a mechanism for adding a hyperlink.

LGTM @SachiniAbeygunawardhana , @leecalcote The code for the events page, renders each member in speakers to a link associated with /community/members/{speakerName}

But in future events, we might not be sure if every speaker has a profile in our community so IMO we can add links to both of the speakers and the one who does not have will get the 404 Page.

So if this is implemented we can have the links like this

Speakers:

@adithyaakrishna thank you, but I had already tried it. I thought it is not appropriate to provide a link that directs to a 404 page, for some speakers. That's why I needed to see whether there is a way to filter out the members who have profiles and provide hyperlinks only for them. In brief, I needed to provide a link for Lee Calcote, but not for Ken Owens in the above scenario.

But, if providing a link which directs to 404 page is okay, I will implement it. @leecalcote

@SachiniAbeygunawardhana you can add a check to see if a member exist. Check PageHeader component for reference. Ping me on slack of you any question regarding this.

Also, @SachiniAbeygunawardhana while you are working on the issue please add the description (in the same PR) as well for this event as mentioned in the description of this issue #1741 . Otherwise, the page looks empty.

Spot on, @SachiniAbeygunawardhana. 404s are always to be avoided. // @Jashpatel1

@SachiniAbeygunawardhana, a quick check-in here.... we're in need of getting this item fixed today (on Friday). Do message if this timeline is too tight and we'll get you switched to another, open issue that isn't as urgently needed. 馃憤

@SachiniAbeygunawardhana, a quick check-in here.... we're in need of getting this item fixed today (on Friday). Do message if this timeline is too tight and we'll get you switched to another, open issue that isn't as urgently needed. 馃憤

@leecalcote I'm really sorry for the delay. I'm already done with the hyperlink. Now I'm working on adding the description as @Nikhil-Ladha requested. Additionally, I figured out that the date of the event is not visible on the particular page as well. An overflow occurs in the SwiperSlide element and I'm trying to fix it. I think I will be able to complete it today.
This is the current view of the page. Only Lee Calcote's name is hyperlinked.
Screenshot_2021-04-09 CNCF SIG Network Intro and Deep Dive

@leecalcote
The main part of the issue - hyperlinking is already fixed and the changes are pushed in to a separate branch.
But it seems a bit hard to render the date and the description to the page. I doubt that it is a overflow, but couldn't fix it yet. As this is needed to be completed today, I have no problem if someone else can look into it too, and I'm really sorry for not be able to add the description.

@SachiniAbeygunawardhana what seems to be the problem with adding the description? Is simply writing HTML on the mdx file not working? You can take a reference of Istiocon workshop.

You can open a PR and I will help in figuring out the issue

@Tanuj22 great suggestion. @SachiniAbeygunawardhana getting a PR up (even in draft) will facilitate the assistance of others.

@Tanuj22 Thanks a lot for the tip. I was trying to add a variable for the description in the mdx file. Simply adding the description as the abstract solved the issue.

really sorry for taking this much time, I'll immediately open up a PR.

Was this page helpful?
0 / 5 - 0 ratings