Layer5: [NG] Use <a> tags instead of <Link>

Created on 5 Dec 2020  路  8Comments  路  Source: layer5io/layer5

Desired Situation
In SocialLinks component use <a> tags instead of <Link> for all the links

[Optional] Alternatives

[Optional] Additional context

Contributor Resources
The layer5 repo contains two websites. The current generation and the next-generation of the layer5.io site.

If the layer5-ng label is absent on this issue, then this issue pertains to the current generation of the layer5.io website, which uses Jekyll and GitHub Pages. Site content is found under the master branch.

If the layer5-ng label is present on this issue, then this issue pertains to the next-generation of the layer5.io website, which uses Gatsby, Strapi, and GitHub Pages. Site content is found under the layer5-ng branch.

good first issue help wanted kinchore layer5-ng
Source
picture Tanuj22

All 8 comments

Is this issue still open @Tanuj22 ? I'd like to work on it!

thadanipaarth picture thadanipaarth on 6 Dec 2020

@thadanipaarth please go ahead

Tanuj22 picture Tanuj22 on 6 Dec 2020
👍1

Excellent. Good of you to jump in, @thadanipaarth. 馃憤

leecalcote picture leecalcote on 7 Dec 2020
👍1

Hey @thadanipaarth , how's it coming up? If stuck anywhere feel free to drop your question in the websites channel in our slack workspace.

Nikhil-Ladha picture Nikhil-Ladha on 10 Dec 2020

I have made the changes and will create PR by EOD. I was going through the documentation of Gatsby and was trying to figure out why exactly are we making this change (https://www.gatsbyjs.com/docs/linking-between-pages/), the documentation mentions this but reasoning is not provided.

thadanipaarth picture thadanipaarth on 10 Dec 2020

I have made the changes and will create PR by EOD. I was going through the documentation of Gatsby and was trying to figure out why exactly are we making this change (https://www.gatsbyjs.com/docs/linking-between-pages/), the documentation mentions this but reasoning is not provided.

is used for navigating in between pages of the site. It prevents reloading of the site and hence doesn't destroy the states which would have occurred for . In this issue, all the links point to external sites so there is no need for . So it says to replace it with

Tanuj22 picture Tanuj22 on 10 Dec 2020

Okayy, I have created the PR. Have a look! I took the liberty to open the social media pages in a new window.

thadanipaarth picture thadanipaarth on 10 Dec 2020

Closing with #1249

Jashpatel1 picture Jashpatel1 on 10 Dec 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues
chinmaym07 picture chinmaym07  路  4Comments
logichub picture logichub  路  4Comments
Aniruddha-Shriwant picture Aniruddha-Shriwant  路  3Comments
leecalcote picture leecalcote  路  3Comments
leecalcote picture leecalcote  路  4Comments