Laravelshoppingcart: Cart is not user safe

Created on 24 Jun 2016 · 8Comments · Source: Crinsane/LaravelShoppingcart

@Crinsane

Pertaining to a previous issue I raised #163, I disagree with the point that the Cart is user safe.

I have two sample users. I added an item using one of the users. Logged out. Then I logged in using the second user account. I can still view the items in the shopping cart added by the previous user. And I am pretty sure that both the accounts are different, as one is an account having admin privileges and the other is not.

I understand the concept of the usage of sessions here. If I log in the same user through a different browser, one browser shows the products in the cart, while other browser doesnt show it.

However, my concern is, if 2 users use the same browser to view the carts, then the contents should be separate for both right? Destroying the contents of the cart when the user logs out is a solution. But ideally, shouldnt be.

Source

gauravojha

Most helpful comment

This is the way how i did it. I'm defining 2 events in EventServiceProvider
'auth.login' => [
'App\Listeners\RestoreCartOnLogin',
],
'auth.logout' => [
'App\Listeners\StoreCartOnLogout',
],
then 2 listeners. one with handle method Cart::store(auth()->id());, other Cart::restore(auth()->id());.Everythink work like charm.
You need Cart::instance(auth()->id()) like Crinsane tip.
Best regards.

raylight75 on 3 Jul 2016

👍4

All 8 comments

I'll look into this later. But for now the best way to make a cart (the session) specific for a given user, is use a custom instance. So for instance try something like: Cart::instance(auth()->id())->add(...);

Crinsane on 24 Jun 2016

The other option would indeed be to clear the cart session when the user logs out.

Crinsane on 24 Jun 2016

Yes it wiil by nice to look into this i have abs.same problem.

raylight75 on 30 Jun 2016

@Crinsane
Thanks for the tip.I ended up creating my own small shopping cart implementation using Eloquent databases instead of using Sessions. Persistence served my purpose. Your tip was working, but I didnt want any user to lose the items they added to their cart if they didnt check out immediately.

gauravojha on 30 Jun 2016

Ok but this with instance is working fine,i just have doubt thath this is right method.

raylight75 on 30 Jun 2016