Laravel-modules: Error '$ROUTES_LOCATION$ after update to 2.5.0

[heliomoreira]

After upgrade to 2.5.0 (before i had 2.4.1) - Laravel 5.5.14 - I got this error:

NwidartModulesModule::main(): Failed opening required 'C:MAMPhtdocsprojectModulesCatalogo$ROUTES_LOCATION$' (include_path='.;C:phppear')

File: start.php

if (!app()->routesAreCached()) {
require __DIR__ . '$ROUTES_LOCATION$'; <-- Error in this line
}

In old modules, this line had:

require __DIR__ . '/Http/routes.php';

[IllyaMoskvin]

I think you need to edit your config/modules.php. Change this line in stubs.replacements:

'start' => ['LOWER_NAME'],

...to this:

'start' => ['LOWER_NAME', 'ROUTES_LOCATION'],

Related to #365, specifically commit 24badff.

[nWidart]

That's correct.

[heliomoreira]

Hi,

Thank you for your answer. I will change the module configuration.

However, its only happened in last version of modules.

Best regards.

[nWidart]

That's because as @IllyaMoskvin pointed out, is only since the last version (2.5)

[heliomoreira]

After change the module config, now I got this error:

_"Cannot declare class ModulesCrudProvidersCrudServiceProvider, because the name is already in use"_ ---- Reported in issue: #373

Another issue is the url reload to www.devdomain.x(...) after this issues.

URL on install

[MrJoelKelly]

Ran into the same problem here after changing the config value. I tried deleting the module manually, config:cache, composer dump-autoload etc. then creating the module again and still running into the same name already in use problem.

[IllyaMoskvin]

@MrJoelKelly Please see issue #373 for the most likely solution. Let us know in that thread if one of the two suggested fixes works for you, or if there's another root cause.

[nWidart]

This is sadly because laravel doesn't merge configurations recursivelly.

[nWidart]

I'll close this as it should be known by now 😄