Laravel-medialibrary: media-library:regenerate doesn't regenerate responsive images

[riasvdv]

If you use

$model
    ->addMediaFromRequest('image')
    ->withResponsiveImages()

And on a later date regenerate the images using php artisan media-library:regenerate, it won't regenerate the responsive images of the base image, only the responsive images of a conversion.

[artem-prozorov]

Hi! If deadline allows, I'd fix this within 1 month

[sebapastore]

Hi, I am trying to make my first contribution to open source. I have been looking into the code the past days and I want to ask your point of view before start coding.

I think that "media-library:regenerate" is working as espected. In the way I see, the command itself can't just know if you want or not responsive images to be generated for the base image. It could infer it by inspecting the "responsive_images" field, but I think this wouldn't be an appropiete aproach.

I think it would be better to provide a bool parameter to the command, and based on this, generate or not responsive images for the base image.

[ctf0]

am also would like to work on this, if anyone would like to join forces, plz reply

[sebapastore]

Hi @ctf0 I would like to help un this one.

[ctf0]

@sebapastore awesome, i've sent u an invitation & we can use https://github.com/ctf0/laravel-medialibrary/issues/1 to discuss how we will tackle this

[sebapastore]

Perfect! 👌

[grantjanecek]

@ctf0 @sebapastore if you need another to help out. I'd love to join join forces with you two.

[ctf0]

@K03413R awesome, plz chk the PR, atm its only missing the tests, if u can help with that it would be perfect

[freekmurze]

This will be fixed by #2047