Laravel-excel: [BUG] Missing ProxyFailure on StoreQueuedExport

[pyr0hu]

Prerequisites

• [X] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
• [X] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
• [X] Checked that your issue isn't already filed.
• [x] Checked if no PR was submitted that fixes this problem.
• [X] Filled in the entire issue template

Versions

• PHP version: 7.3.9-1+ubuntu16.04.1+deb.sury.org+1
• Laravel version: 6.1.0
• Package version: 3.1.17

Description

The StoreQueuedExport class does not use the ProxyFailure trait therefore errors cannot be handled properly if there are issues with storing the file.

Steps to Reproduce

Expected behavior:

StoreQueuedExport should call the failure method on the export class so the developers can handle the errors on their export classes with the failure method, just like with AppendDataToSheet classes.

Actual behavior:

Any error that happens during storing the file is not caught and cannot be handled by the developers.

Additional Information

None

[patrickbrouwers]

It's best to directly create a PR in these cases. It's easier to discuss, see test running etc. Thanks

[pyr0hu]

Ah okay, will do that then :)

[patrickbrouwers]

Closing this ticket due to inactivity.

For future reference: we can't add the ProxyFailures trait at the moment, because the job doesn't receive the sheet export class.

3.2 will change the entire queuing stuff a bit, will take this issue into account if applicable still.