Laravel-adminlte: Submenu "active checking" does not work when using "route"

Created on 7 Sep 2017 · 9Comments · Source: jeroennoten/Laravel-AdminLTE

When I set the "route" option in the submenu items, the menu is not being shown as active on those pages.

It works when i set the route of an item without a submenu though.

example:

[
   'text' => 'Item',
   'route' => 'item-route'
]

^^ This will work, and the item will be active when viewing the page.

[
   'text' => 'Parent',
   'submenu' => [
      [
         'text' => 'Child',
         'route' => 'item-child'
      ]
   ]
]

^^ This will not work. When viewing the child page, the menu is not expanded and the page is not shown as active.

bug

Source

roblesterjr04

All 9 comments

Thanks for the bug report. I am looking for a way to fix this. A PR that fixes this issue is more than welcome. I already made up a failing test case:

    public function testSubmenuActiveWithRoute()
    {
        $builder = $this->makeMenuBuilder('http://example.com/about');
        $this->getRouteCollection()->add(new Route('GET', 'about', ['as' => 'pages.about']));

        $builder->add(['submenu' => [['text' => 'About', 'route' => 'pages.about']]]);

        $this->assertTrue($builder->menu[0]['active']);
    }

jeroennoten on 8 Sep 2017

Is this test case for phpunit or dusk? The test case won't run because none of those methods are part of the test object. Am I missing something here?

roblesterjr04 on 25 Sep 2017

In order to run the test suite, clone this repository and run phpunit. You should indeed not run these test within your own project.

jeroennoten on 25 Sep 2017

I fixed it. Issue was in the HrefFilter. It wasn't interating through the submenus to generate the hrefs from routes before the active filter was applied. Also fixed an issue in the active filter that caused all sub items to become active when the paths were like: /company, /company/create - When going to create, both /company and /company/create were lit up. This was at any time, not just when routes were used. Simplified active filter code.

PR on the way.

roblesterjr04 on 25 Sep 2017

Disregard the second issue, the HrefFilter fixes the original problem.

I will create another issue for the multiple active problem.

roblesterjr04 on 25 Sep 2017

How can I integrate jeroennoten/Laravel-AdminLTE with Zizaco/entrust?

I am interested in integrating jeroennoten/Laravel-AdminLTE with Zizaco/entrust, for the management of roles and persmisos.

I have used both but I have to build an independent menu assigning the roles and permissions.

How can I do this without affecting component integrity?