Larastan: The logic in getProjectClasses is dangerous

[szepeviktor]

@ondrejmirtes said

Anyway, the logic in getProjectClasses is dangerous and shouldn't be done this way...

See #273

[szepeviktor]

@nunomaduro Could you contribute a little when you get back from SF?

[nunomaduro]

@szepeviktor I don't work that much with Laravel anymore, sorry.

[nunomaduro]

@szepeviktor Would be cool find people that would like to maintain this project.

[CyberiaResurrection]

@nunomaduro , @szepeviktor, @canvural , since #318 has been rolled up, can this issue be closed?

[canvural]

Sure. Thanks for the PR :+1:

[nunomaduro]

@canvural Fell free to perform NON breaking new releases: https://github.com/nunomaduro/larastan/blob/master/RELEASE.md. The next one should be v0.4.2.

[canvural]

@nunomaduro I can't push directly to master, so I can't make new releases. How do you wanna do that? Should I open PR for CHANGELOG, and then try to use the GitHub's release tool?

[szepeviktor]

@canvural Even if you work on a project alone please consider not pushing to master.

I could open a PR for you regarding the changelog :)

[canvural]

@szepeviktor I already have the changes I can create the PR.

But to create the tags etc. we still need to push it to master. I don't see a downside. Also, that's what written in the release document.

[szepeviktor]

I think @nunomaduro has more liberal views on project management than I do.

We may create a tag on the release page https://github.com/nunomaduro/larastan/releases/new