Larastan: Higher Order Proxy functions

[jkniest]

• Larastan Version: 0.3.8
• default level used:

Description:

I am using the higher order proxy methods of collections, for example "map". The error message I get is: Access to an undefined property Illuminate\Support\HigherOrderCollectionProxy::$id.

Laravel code where the issue was found:

        return collect($room->getLights())->map(function (HueLight $hueLight) {
            return Light::whereExternalId($hueLight->getId())->first();
        })->map->id;

[nunomaduro]

Thanks for reporting this. We don't support Higher Order Proxy functions, yet.

[mfn]

Just to add another example, it's not only about attributes, also methods:

$post->attachments->map->getAttributes()->all();

yields

    Call to an undefined method
    Illuminate\Support\HigherOrderCollectionProxy::getAttributes().

[szepeviktor]

Yes, I've seen this error message.

[canvural]

This can be solved by the PHPStan generics to some extent. But there would be some edge cases I think.

I would accept a PR that adds a support for this :+1:

[nmokkenstorm]

I would accept a PR that adds a support for this 👍

I created a plugin that fixes this, and extracted it to a package over here today. Do I clean up the package and add it as a dependency, or is porting the code directly to this repository preferable?

[canvural]

@nmokkenstorm I'd prefer the functionality inside the Larastan. With proper implementation and tests. Feel free to make a PR :+1:

[szepeviktor]

I would gladly see @nmokkenstorm's extension in Larastan ❤️