Larastan: Does not work on Windows

[jameslkingsley]

'.' is not recognized as an internal or external command, operable program or batch file.

Looks like it's to do with Console\CodeAnalyseCommand line 42.

[nunomaduro]

@jameslkingsley Can you please do a composer update nunomaduro/laravel-code-analyse and test again?

Thanks for feedback/help. But for information you shouldn't use this on production or real case scenarios. The package is still in development. 👍

[jameslkingsley]

I did that, and it solved the issue. However I am now getting this printed out in the console:

dir=$(cd "${0%[/\\]*}" > /dev/null; cd "../phpstan/phpstan/bin" && pwd)

if [ -d /proc/cygdrive ] && [[ $(which php) == $(readlink -n /proc/cygdrive)/* ]]; then
   # We are in Cgywin using Windows php, so the path must be translated
   dir=$(cygpath -m "$dir");
fi

"${dir}/phpstan" "$@"

[nunomaduro]

@jameslkingsley Ok. I need to take a deeper look on this. Thanks.

[ChristopheB]

Removing php from php phpstan here does the trick for me (so the line would be just 'phpstan',).

Not sure how it would impact other platforms though.

[nunomaduro]

@ChristopheB @jameslkingsley Can you test now? Just used the solution that exists on laravel.

[jameslkingsley]

Same error as before:

dir=$(cd "${0%[/\\]*}" > /dev/null; cd "../phpstan/phpstan/bin" && pwd)

if [ -d /proc/cygdrive ] && [[ $(which php) == $(readlink -n /proc/cygdrive)/* ]]; then
   # We are in Cgywin using Windows php, so the path must be translated
   dir=$(cygpath -m "$dir");
fi

"${dir}/phpstan" "$@"

[nunomaduro]

@jameslkingsley Have you made composer update nunomaduro/laravel-code-analyse?

[ChristopheB]

I confirm that it does not work using the full path from Artisan::phpBinary().

Please note that there are some special .bat files for Windows in vendor/bin, which can be used directly, so maybe there is no need to prefix the command with php at all.

[jameslkingsley]

I did @nunomaduro

[nunomaduro]

@jameslkingsley @ChristopheB How about now? Just made the solution you both proposed.

[ChristopheB]

It works thanks! :ok_hand:

[jameslkingsley]

Works for me too!

[ChristopheB]

Just to say, I use Laragon (I dropped Homestead and VMs).