Lagom: Lagom Dependencies has scalatest twice

[ignasi35]

See https://github.com/lagom/lagom/blob/c9c44b9f8827392dbf9df7c859a8c145fe4681a0/project/Dependencies.scala#L215 and https://github.com/lagom/lagom/blob/c9c44b9f8827392dbf9df7c859a8c145fe4681a0/project/Dependencies.scala#L65

I think https://github.com/lagom/lagom/blob/c9c44b9f8827392dbf9df7c859a8c145fe4681a0/project/Dependencies.scala#L215 may be removed.

[erip]

Library so nice, gotta have it twice.

[TimMoore]

Took a closer look, and these aren't exactly redundant. Line 215 is adding it to the whitelist. Line 65 is only declaring a variable that can be used in other places, such as:

https://github.com/lagom/lagom/blob/c9c44b9f8827392dbf9df7c859a8c145fe4681a0/project/Dependencies.scala#L317

https://github.com/lagom/lagom/blob/c9c44b9f8827392dbf9df7c859a8c145fe4681a0/project/Dependencies.scala#L334

…and many more. So we can't remove either one.

What we _could_ do is use the variable in the whitelist, rather than repeating the definition. It would be a nice cleanup.

[ayushprashar]

@ignasi35 I would like to work on this issue.

[TimMoore]

Fixed in #1490. Thanks, @ayushprashar!