Lagom: Update sbt to 0.13.15

Created on 11 Apr 2017  路  8Comments  路  Source: lagom/lagom

sbt 0.13.15 has been released (0.13.14 was skipped): http://www.scala-sbt.org/0.13/docs/sbt-0.13-Tech-Previews.html#sbt+0.13.15

Before doing this, #391 should be completed.

As part of this update, the remaining deprecation warnings where triggeredBy, etc. are used should be fixed.

We'll also want to update all of the sample apps once this is released.

Most helpful comment

@erip I believe you are more or less correct, but we should also fix the rest of the deprecation warnings as part of updating. This has just been waiting for someone to be free to do it. If you'd like to volunteer, that would be greatly appreciated!

In lagom/lagom, there is also the separate documentation build in docs/build.sbt/docs/project/build.properties. This build still seems to have some other deprecation warnings, as well, that I missed in #391.

All 8 comments

391 has been closed, but there are merged commits. What's the status for this (#666)? Good to go?

This seems like a very simple request... bump project/build.properties in....

  • [x] lagom/lagom
  • [x] lagom/online-auction-java
  • [x] lagom/online-auction-scala
  • [x] lagom/activator-lagom-java-chirper
  • [x] lagom/lagom-java.g8
  • [x] lagom/lagom-scala.g8
  • [x] lagom/activator-lagom-java
  • [x] lagom/sbt-lagom-descriptor-generator
  • [x] lagom/grpc-sbt-experiments
  • [x] lagom/activator-lagom-cargotracker
  • [x] lagom/lagom-at-so

Is this right -- just changing one number in each of these repos?

Update: checks indicate that CI _passed_, not that the PR was accepted.

@erip I believe you are more or less correct, but we should also fix the rest of the deprecation warnings as part of updating. This has just been waiting for someone to be free to do it. If you'd like to volunteer, that would be greatly appreciated!

In lagom/lagom, there is also the separate documentation build in docs/build.sbt/docs/project/build.properties. This build still seems to have some other deprecation warnings, as well, that I missed in #391.

Sure thing. Can do this.

I'm not 100% sure that my course of action is right because I think the template version might need to bumped in all lagom-dependent projects before the associated PR with that project is accepted... if that's the case, I can just revert the commits and fix them. 馃槃

@erip I don't totally understand your last comment (when you say "template version" do you mean the version of Lagom they use?) but I think you're on the right track. I merged most of your pull requests other than the one in lagom/lagom (which has a failing test).

In general, the version of sbt used to build each of these projects is independent from the version used to build the core framework (unless something is added to the Lagom sbt plugin that relies on changes in a newer sbt version, which isn't the case here). It's still good to be consistent for simplicity's sake.

lagom/sbt-lagom-descriptor-generator's build was failing prior to this update, so it'll be a little less clear to see that the changes don't affect the build. I'll leave that one for you all. 馃槃 Everything else should be good, though!

_Update_: errors are consistent with those from previous failing build, so _I'm_ convinced that I didn't exacerbate... This 馃槇 issue is almost done. ha

Thanks for all of your effort on this one, @erip! 馃帀

We haven't reviewed & merged all of the pull requests yet, but we got all of the essential ones.

Absolutely no problem. If you need any updates, feel free to let me know.

Was this page helpful?
0 / 5 - 0 ratings