Describe the bug
The text tag has a parameter selelectWithoutLabel. It should be selectWithoutLabel. I am hesitant to offer a pull request because a change could break users' existing solutions. A deprecation strategy is suggested, and I'm not sure how to do that with your code.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The label should be selectWithoutLabel.
@kgeis Hi! I'm not sure about default state is _withoutLabel_.
The main reasons:
But I think it's a good idea to create more concise names of parameters for tags. For example change selectWithoutLabel to emptyLabel (or similar).
@shevchenkonik, I don't understand your comment. I'm just saying that the parameter name has an extra "le" in it. Maybe this makes it more clear: se<le>lectWithoutLabel
@kgeis haha I did not notice typos :)
Yes, you are right about deprecation strategy and in the the current version we can leave a selelectWithoutLabel and add new one as selectWithoutLabel (and add TODO comment):
/** TODO */
if (!self.selelectwithoutlabel || !self.selectwithoutlabel) /** ... */;
In the next major release, we will update the logic of this tag and will add major release note.
@kgeis Thanks for reporting. That was fixed in the latest release