The error.response on https://github.com/sindresorhus/ky/blob/master/index.js#L374
is undefined when the error is AbortError.
Should I catch that exception in the retry function?
lambdalisue
All 2 comments
I'm sorry. I could not reproduce this error on Google Chrome / Safari thus might be my Firefox is broken.
lambdalisue
on 27 Apr 2020
This looks like a legit bug in Ky, unfortunately. The error may not have a response on it, which we don't check before attempting to clone it.
In hindsight, I'm kind of regretting https://github.com/sindresorhus/ky/pull/201. People should almost certainly just use error.response. This shortcut provides very little value. Most people are going to destructure the options anyway. I also think that, from the hook's perspective, it's more obvious that options.error.response may be undefined, as opposed to options.response.
sholladay
on 27 Apr 2020
Related issues
sarneeh
路
6Comments
davalapar
路
6Comments
Splact
路
7Comments
jacob-fueled
路
3Comments
luxferresum
路
7Comments
Most helpful comment
This looks like a legit bug in Ky, unfortunately. The error may not have a response on it, which we don't check before attempting to clone it.
In hindsight, I'm kind of regretting https://github.com/sindresorhus/ky/pull/201. People should almost certainly just use
error.response. This shortcut provides very little value. Most people are going to destructure the options anyway. I also think that, from the hook's perspective, it's more obvious thatoptions.error.responsemay be undefined, as opposed tooptions.response.