Kubespray: glusterfs role for Debian uses "state: installed" instead of "state: present"

[davidcarrera]

Environment:

• Cloud provider or hardware configuration:

Generic x86 servers (bare metal)

• OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 4.18.0-24-generic x86_64
NAME="Ubuntu"
VERSION="18.04.2 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.2 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

• Version of Ansible (ansible --version):

ansible 2.9.6
config file = /root/kubespray/ansible.cfg
configured module search path = ['/root/kubespray/library']
ansible python module location = /usr/local/lib/python3.6/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 3.6.8 (default, Jan 14 2019, 11:02:34) [GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]

• Version of Python (python --version):

Python 3.6.8

Kubespray version (commit) (git rev-parse --short HEAD):

641a2a8b

Network plugin used:

Calico

Full inventory with variables (ansible -i inventory/sample/inventory.ini all -m debug -a "var=hostvars[inventory_hostname]"):

Command used to invoke ansible:
ansible-playbook -b --become-user=root -i inventory/covid/hosts.yaml --become --become-user=root contrib/network-storage/glusterfs/glusterfs.yml

Output of ansible run:

TASK [glusterfs/server : Ensure GlusterFS is installed.] *****************************************************************************************************
failed: [node1] (item=['glusterfs-server', 'glusterfs-client']) => {"ansible_loop_var": "item", "changed": false, "item": ["glusterfs-server", "glusterfs-client"], "msg": "value of state must be one of: absent, build-dep, fixed, latest, present, got: installed"}
failed: [node3] (item=['glusterfs-server', 'glusterfs-client']) => {"ansible_loop_var": "item", "changed": false, "item": ["glusterfs-server", "glusterfs-client"], "msg": "value of state must be one of: absent, build-dep, fixed, latest, present, got: installed"}
failed: [node2] (item=['glusterfs-server', 'glusterfs-client']) => {"ansible_loop_var": "item", "changed": false, "item": ["glusterfs-server", "glusterfs-client"], "msg": "value of state must be one of: absent, build-dep, fixed, latest, present, got: installed"}

Anything else do we need to know:
The GlusterFS roles in roles/glusterfs/server/tasks/setup-Debian.yml and roles/glusterfs/client/tasks/setup-Debian.yml
are using "state: installed" instead of "state: present".

[floryut]

@davidcarrera Thank you for finding this, are you available to make a PR ? (otherwise we'll fix it of course)

[qckzr]

Hey there, I can submit a PR fixing this issue