Kubespray: Master label should be `node-role.kubernetes.io/master: ""`

Created on 22 Dec 2017 · 6Comments · Source: kubernetes-sigs/kubespray

It seems that kubespray applies the label node-role.kubernetes.io/master: "true" but kubeadm design doc says it should be node-role.kubernetes.io/master: ""

https://github.com/kubernetes/kubeadm/blob/master/docs/design/design_v1.9.md#mark-master

cc: @luxas

lifecyclrotten

Source

tamalsaha

👍4

Most helpful comment

This sounds like a Prometheus bug.

tamalsaha on 26 Dec 2017

👍5

All 6 comments

/kind bug

tamalsaha on 22 Dec 2017

Counterpoint, Prometheus cannot handle empty labels, and hence it is tricky to distinguish master nodes from regular nodes:

https://github.com/coreos/tectonic-installer/issues/1439

towolf on 25 Dec 2017

This sounds like a Prometheus bug.

tamalsaha on 26 Dec 2017

👍5

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 10 Apr 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 11 May 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.