Kubernetes: Eliminate shellcheck failures

Created on 16 Jan 2019 · 120Comments · Source: kubernetes/kubernetes

What happened: After #24614 / #68438 we had 283 known failing *.sh files being excluded from shellcheck lints.

What you expected to happen: We should be linting all files. When files are listed in hack/.shellcheck_failures we may miss actual bugs in them. Initially to get the linter in place we had to list many files there to keep the PR reasonably sized, but ideally we can fix these over time and eliminate this file.

How to reproduce it (as minimally and precisely as possible): hack/verify-shellcheck.sh

Anything else we need to know?: I intend to continue working on this, EG #72861, #72955, ...

/sig testing
/assign

Known failing files TODO:

[x] ./build/build-image/rsyncd.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/common.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73117)
[x] ./build/copy-output.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/lib/release.sh
[x] ./build/make-build-image.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/make-clean.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/package-tarballs.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/release-images.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/release-in-a-container.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/release.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/run.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/shell.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./build/util.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72955)
[x] ./cluster/addons/addon-manager/kube-addons.sh
[x] ./cluster/addons/fluentd-elasticsearch/es-image/run.sh
[x] ./cluster/addons/fluentd-elasticsearch/fluentd-es-image/run.sh
[x] ./cluster/centos/build.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/config-build.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/config-default.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/config-test.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/deployAddons.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/make-ca-cert.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/master/scripts/flannel.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/node/bin/mk-docker-opts.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/node/scripts/flannel.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/centos/util.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73253)
[x] ./cluster/clientbin.sh
[x] ./cluster/common.sh
[x] ./cluster/gce/config-common.sh
[x] ./cluster/gce/config-default.sh
[x] ./cluster/gce/config-test.sh
[x] ./cluster/gce/delete-stranded-load-balancers.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74192)
[ ] ./cluster/gce/gci/configure-helper.sh
[ ] ./cluster/gce/gci/configure.sh
[x] ./cluster/gce/gci/flexvolume_node_setup.sh
[x] ./cluster/gce/gci/health-monitor.sh
[ ] ./cluster/gce/gci/master-helper.sh
[x] ./cluster/gce/gci/mounter/stage-upload.sh
[x] ./cluster/gce/gci/node-helper.sh
[x] ./cluster/gce/gci/shutdown.sh
[x] ./cluster/gce/list-resources.sh
[x] ./cluster/gce/upgrade-aliases.sh
[x] ./cluster/gce/upgrade.sh
[ ] ./cluster/gce/util.sh
[x] ./cluster/get-kube-binaries.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72861)
[x] ./cluster/get-kube-local.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72861)
[x] ./cluster/get-kube.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72861)
[x] ./cluster/images/conformance/run_e2e.sh
[x] ./cluster/images/etcd-empty-dir-cleanup/etcd-empty-dir-cleanup.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74192)
[x] ./cluster/juju/prereqs/ubuntu-juju.sh
[x] ./cluster/juju/util.sh
[x] ./cluster/kube-down.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74060)
[x] ./cluster/kube-up.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74449)
[x] ./cluster/kube-util.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74449)
[x] ./cluster/kubeadm.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74060)
[x] ./cluster/kubectl.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74449)
[x] ./cluster/kubemark/gce/config-default.sh
[x] ./cluster/kubemark/iks/config-default.sh
[x] ./cluster/kubemark/util.sh
[x] ./cluster/local/util.sh
[ ] ./cluster/log-dump/log-dump.sh
[x] ./cluster/pre-existing/util.sh
[x] ./cluster/restore-from-backup.sh
[x] ./cluster/test-e2e.sh
[x] ./cluster/test-network.sh
[x] ./cluster/test-smoke.sh
[x] ./cluster/update-storage-objects.sh
[x] ./cluster/validate-cluster.sh
[x] ./hack/benchmark-go.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74299)
[x] ./hack/build-cross.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74299)
[x] ./hack/build-go.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74299)
[x] ./hack/build-ui.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72924)
[x] ./hack/cherry_pick_pull.sh
[x] ./hack/dev-build-and-push.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73151)
[x] ./hack/dev-build-and-up.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73151)
[x] ./hack/dev-push-conformance.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73151)
[x] ./hack/dev-push-hyperkube.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73151)
[x] ./hack/e2e-internal/e2e-cluster-size.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/e2e-internal/e2e-down.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/e2e-internal/e2e-grow-cluster.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/e2e-internal/e2e-shrink-cluster.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/e2e-internal/e2e-status.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/e2e-internal/e2e-up.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/e2e-node-test.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74230)
[x] ./hack/generate-bindata.sh
[x] ./hack/generate-docs.sh
[x] ./hack/get-build.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74060)
[x] ./hack/ginkgo-e2e.sh
[x] ./hack/godep-restore.sh
[x] ./hack/godep-save.sh
[x] ./hack/grab-profiles.sh
[x] ./hack/install-etcd.sh
[x] ./hack/jenkins/benchmark-dockerized.sh
[x] ./hack/jenkins/build.sh
[x] ./hack/jenkins/test-dockerized.sh
[x] ./hack/jenkins/upload-to-gcs.sh
[x] ./hack/jenkins/verify-dockerized.sh
[x] ./hack/lib/etcd.sh
[x] ./hack/lib/golang.sh
[x] ./hack/lib/init.sh
[x] ./hack/lib/logging.sh
[x] ./hack/lib/protoc.sh
[x] ./hack/lib/swagger.sh
[x] ./hack/lib/test.sh
[x] ./hack/lib/util.sh
[x] ./hack/lib/version.sh
[x] ./hack/list-feature-tests.sh
[x] ./hack/local-up-cluster.sh
[x] ./hack/make-rules/build.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74242)
[x] ./hack/make-rules/clean.sh
[x] ./hack/make-rules/cross.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74242)
[x] ./hack/make-rules/helpers/cache_go_dirs.sh
[x] ./hack/make-rules/make-help.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74242)
[x] ./hack/make-rules/test-cmd.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74242)
[x] ./hack/make-rules/test-e2e-node.sh
[x] ./hack/make-rules/test-integration.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74242)
[x] ./hack/make-rules/test-kubeadm-cmd.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74242)
[x] ./hack/make-rules/test.sh
[x] ./hack/make-rules/update.sh
[x] ./hack/make-rules/verify.sh
[x] ./hack/make-rules/vet.sh
[x] ./hack/print-workspace-status.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73257)
[x] ./hack/run-in-gopath.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73257)
[x] ./hack/test-go.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74299)
[x] ./hack/test-integration.sh
[x] ./hack/test-update-storage-objects.sh
[x] ./hack/update-all.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74299)
[x] ./hack/update-api-reference-docs.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72924)
[x] ./hack/update-bazel.sh
[x] ./hack/update-codegen.sh
[x] ./hack/update-generated-device-plugin-dockerized.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-device-plugin.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-docs.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-kms-dockerized.sh
[x] ./hack/update-generated-kms.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-kubelet-plugin-registration-dockerized.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-kubelet-plugin-registration.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-pod-resources-dockerized.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-pod-resources.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-protobuf-dockerized.sh
[x] ./hack/update-generated-protobuf.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74286)
[x] ./hack/update-generated-runtime-dockerized.sh
[x] ./hack/update-generated-runtime.sh
[x] ./hack/update-generated-swagger-docs.sh
[x] ./hack/update-godep-licenses.sh
[x] ./hack/update-gofmt.sh
[x] ./hack/update-openapi-spec.sh
[x] ./hack/update-staging-godeps-dockerized.sh
[x] ./hack/update-staging-godeps.sh
[x] ./hack/update-swagger-spec.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72924)
[x] ./hack/update-translations.sh
[x] ./hack/update-workspace-mirror.sh
[x] ./hack/verify-all.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74299)
[x] ./hack/verify-api-groups.sh
[x] ./hack/verify-api-reference-docs.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72924)
[x] ./hack/verify-bazel.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74259)
[x] ./hack/verify-boilerplate.sh
[x] ./hack/verify-cli-conventions.sh
[x] ./hack/verify-codegen.sh
[x] ./hack/verify-description.sh
[x] ./hack/verify-generated-device-plugin.sh
[x] ./hack/verify-generated-docs.sh
[x] ./hack/verify-generated-files-remake.sh
[x] ./hack/verify-generated-files.sh
[x] ./hack/verify-generated-kms.sh
[x] ./hack/verify-generated-kubelet-plugin-registration.sh
[x] ./hack/verify-generated-pod-resources.sh
[x] ./hack/verify-generated-protobuf.sh
[x] ./hack/verify-generated-runtime.sh
[x] ./hack/verify-generated-swagger-docs.sh
[x] ./hack/verify-godep-licenses.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74259)
[x] ./hack/verify-godeps.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74259)
[x] ./hack/verify-gofmt.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74259)
[x] ./hack/verify-golint.sh
[x] ./hack/verify-govet.sh
[x] ./hack/verify-import-boss.sh
[x] ./hack/verify-imports.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74259)
[x] ./hack/verify-linkcheck.sh
[x] ./hack/verify-no-vendor-cycles.sh
[x] ./hack/verify-openapi-spec.sh
[x] ./hack/verify-pkg-names.sh
[x] ./hack/verify-readonly-packages.sh
[x] ./hack/verify-spelling.sh
[x] ./hack/verify-staging-godeps.sh
[x] ./hack/verify-staging-meta-files.sh
[x] ./hack/verify-swagger-spec.sh (Done in: https://github.com/kubernetes/kubernetes/pull/72924)
[x] ./hack/verify-symbols.sh
[x] ./hack/verify-test-featuregates.sh
[x] ./hack/verify-test-images.sh
[x] ./hack/verify-test-owners.sh
[x] ./hack/verify-typecheck.sh
[x] ./pkg/kubectl/cmd/edit/testdata/record_testcase.sh
[x] ./pkg/util/verify-util-pkg.sh
[x] ./plugin/pkg/admission/imagepolicy/gencerts.sh
[x] ./staging/src/k8s.io/apiextensions-apiserver/examples/client-go/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73252)
[x] ./staging/src/k8s.io/apiextensions-apiserver/examples/client-go/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73252)
[x] ./staging/src/k8s.io/apiextensions-apiserver/hack/build-image.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73252)
[x] ./staging/src/k8s.io/apiextensions-apiserver/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73252)
[x] ./staging/src/k8s.io/apiextensions-apiserver/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73252)
[x] ./staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/testcerts/gencerts.sh
[x] ./staging/src/k8s.io/apiserver/pkg/util/webhook/gencerts.sh
[x] ./staging/src/k8s.io/apiserver/plugin/pkg/authenticator/token/oidc/testdata/gen.sh
[x] ./staging/src/k8s.io/apiserver/plugin/pkg/authorizer/webhook/gencerts.sh
[x] ./staging/src/k8s.io/code-generator/generate-groups.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73246)
[x] ./staging/src/k8s.io/code-generator/generate-internal-groups.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73246)
[x] ./staging/src/k8s.io/code-generator/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73246)
[x] ./staging/src/k8s.io/code-generator/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73246)
[x] ./staging/src/k8s.io/csi-api/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73219)
[x] ./staging/src/k8s.io/csi-api/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73219)
[x] ./staging/src/k8s.io/kube-aggregator/hack/build-image.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73218)
[x] ./staging/src/k8s.io/kube-aggregator/hack/local-up-kube-aggregator.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73218)
[x] ./staging/src/k8s.io/kube-aggregator/hack/register-all-apis-from.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73218)
[x] ./staging/src/k8s.io/kube-aggregator/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73218)
[x] ./staging/src/k8s.io/kube-aggregator/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73218)
[x] ./staging/src/k8s.io/metrics/hack/update-codegen.sh
[x] ./staging/src/k8s.io/metrics/hack/verify-codegen.sh
[x] ./staging/src/k8s.io/node-api/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73213)
[x] ./staging/src/k8s.io/node-api/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73213)
[x] ./staging/src/k8s.io/sample-apiserver/hack/build-image.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73210)
[x] ./staging/src/k8s.io/sample-apiserver/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73210)
[x] ./staging/src/k8s.io/sample-apiserver/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73210)
[x] ./staging/src/k8s.io/sample-controller/hack/update-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73213)
[x] ./staging/src/k8s.io/sample-controller/hack/verify-codegen.sh (Done in: https://github.com/kubernetes/kubernetes/pull/73213)
[x] ./test/cmd/apply.sh
[x] ./test/cmd/apps.sh
[x] ./test/cmd/authorization.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/batch.sh
[x] ./test/cmd/certificate.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/core.sh
[x] ./test/cmd/crd.sh
[x] ./test/cmd/create.sh
[x] ./test/cmd/delete.sh
[x] ./test/cmd/diff.sh
[x] ./test/cmd/discovery.sh
[x] ./test/cmd/generic-resources.sh
[x] ./test/cmd/get.sh
[x] ./test/cmd/initializers.sh
[x] ./test/cmd/legacy-script.sh
[x] ./test/cmd/node-management.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/old-print.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/proxy.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/rbac.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/request-timeout.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/run.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/save-config.sh
[x] ./test/cmd/storage.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/template-output.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/cmd/version.sh (Addressed in: https://github.com/kubernetes/kubernetes/pull/74279)
[x] ./test/e2e_node/conformance/run_test.sh
[x] ./test/e2e_node/environment/setup_host.sh
[x] ./test/e2e_node/gubernator.sh
[x] ./test/e2e_node/jenkins/conformance/conformance-jenkins.sh
[x] ./test/e2e_node/jenkins/copy-e2e-image.sh
[x] ./test/e2e_node/jenkins/e2e-node-jenkins.sh
[x] ./test/e2e_node/jenkins/ubuntu-14.04-nvidia-install.sh
[x] ./test/images/image-util.sh
[x] ./test/images/pets/redis-installer/on-start.sh
[x] ./test/images/pets/zookeeper-installer/install.sh
[x] ./test/images/pets/zookeeper-installer/on-start.sh
[x] ./test/images/volume/gluster/run_gluster.sh
[x] ./test/images/volume/iscsi/create_block.sh
[x] ./test/images/volume/nfs/run_nfs.sh
[x] ./test/images/volume/rbd/bootstrap.sh
[x] ./test/images/volume/rbd/create_block.sh
[x] ./test/images/volume/rbd/mon.sh
[x] ./test/images/volume/rbd/osd.sh
[x] ./test/integration/ipamperf/test-performance.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74193)
[x] ./test/integration/scheduler_perf/test-performance.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74193)
[x] ./test/kubemark/common/util.sh
[x] ./test/kubemark/configure-kubectl.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74193)
[x] ./test/kubemark/gce/util.sh
[x] ./test/kubemark/iks/shutdown.sh
[x] ./test/kubemark/iks/startup.sh
[x] ./test/kubemark/iks/util.sh
[x] ./test/kubemark/master-log-dump.sh
[x] ./test/kubemark/pre-existing/util.sh (Done in: https://github.com/kubernetes/kubernetes/pull/74193)
[x] ./test/kubemark/resources/start-kubemark-master.sh
[x] ./test/kubemark/run-e2e-tests.sh
[x] ./test/kubemark/start-kubemark.sh
[x] ./test/kubemark/stop-kubemark.sh
[x] ./third_party/forked/shell2junit/sh2ju.sh
[x] ./third_party/intemp/intemp.sh
[x] ./third_party/multiarch/qemu-user-static/register/qemu-binfmt-conf.sh
[x] ./third_party/multiarch/qemu-user-static/register/register.sh

help wanted kincleanup prioritimportant-longterm sitesting

Source

BenTheElder

👍5 👀2 ❤1

Most helpful comment

A bit of advice for those working on this: make it easy on your reviewers. Explain why you're changing what you're changing. "Fixing shellcheck failures" is not enough context.

Some details that could help your reviewer:

what shellcheck failure are you fixing?
why are you doing it this way?
why is this more maintainable than what was there before?
if you need to ignore a shellcheck failure, why? is there some other way of doing things that would accomplish the same goals and _not_ trigger shellcheck?

spiffxp on 23 Feb 2019

👍3

All 120 comments

@spiffxp I am tackling this optimistically for 1.14, but I could see it slipping to 1.15 depending on time-to-review, bandwidth, etc..

BenTheElder on 16 Jan 2019

/priority important-longterm

BenTheElder on 16 Jan 2019

/milestone v1.14

spiffxp on 18 Jan 2019

👍2

@BenTheElder would it be ok if I helped out with this? I was thinking I could go through and cover the scripts in ./cluster/centos/ to start with

phenixblue on 19 Jan 2019

👍2

That would be great! there's a _lot_ to tackle here :sweat_smile:

If you could reference this issue (just include a link somewhere, please don't mark it as "fixes #" :upside_down_face:) that would be helpful for attempting to avoid overlap :-)
I'll continue to do the same as I get to more of these.

BenTheElder on 19 Jan 2019

👍1

@BenTheElder
Can I help with ./build/common.sh

war-turtle on 21 Jan 2019

👍1

Go for it! 🙂
We might even want multiple PRs for that one - If I remember correctly,
there was plenty to fix in that one 😛

On Sun, Jan 20, 2019, 15:07 Kartik Yadav <[email protected] wrote:

@BenTheElder https://github.com/BenTheElder
Can I help with ./build/common.sh

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956#issuecomment-455911313,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4BqwY2Ny9UJxZ9htOYQYpUBnuy9XNnks5vFPakgaJpZM4aClvY
.

BenTheElder on 21 Jan 2019

I will fix
./hack/dev-build-and-push.sh
./hack/dev-build-and-up.sh
./hack/dev-push-conformance.sh
./hack/dev-push-hyperkube.sh

tanshanshan on 21 Jan 2019

👍1

I'll work on the scripts in ./cluster/gce/

phenixblue on 22 Jan 2019

👍1

I will fix
./cluster/addons/addon-manager/kube-addons.sh
./cluster/addons/fluentd-elasticsearch/es-image/run.sh
./cluster/addons/fluentd-elasticsearch/fluentd-es-image/run.sh

mysunshine92 on 23 Jan 2019

I will fix ./staging/

danielqsj on 23 Jan 2019

/help
[we have various people contributing, but there's so many of these to tackle!]

BenTheElder on 24 Jan 2019

@BenTheElder:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
[we have various people contributing, but there's so many of these to tackle!]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot on 24 Jan 2019

I will fix:

./hack/print-workspace-status.sh
./hack/run-in-gopath.sh
./hack/test-go.sh
./hack/test-integration.sh

ds-ms on 24 Jan 2019

I will fix:

./hack/print-workspace-status.sh
./hack/run-in-gopath.sh
./hack/test-go.sh
./hack/test-integration.sh

@ds-ms i have fix /hack/test-go.sh and /hack/test-integration.sh in #73199

mysunshine92 on 24 Jan 2019

i will fix /cluster/common.sh

mysunshine92 on 24 Jan 2019

@mysunshine92 I've reverted my changes from those 2 files.

ds-ms on 24 Jan 2019

I will fix ./cluster/juju and ./cluster/local

danielqsj on 24 Jan 2019

I'd like to fix files under ./test/cmd/.

xychu on 28 Jan 2019

I'm fixing hack/verify-generated-files-remake.sh at https://github.com/kubernetes/kubernetes/pull/73464.

ipuustin on 31 Jan 2019

I'd like to fix files under /test/e2e_node.
FYI: ./hack/lib/test.sh have been included in https://github.com/kubernetes/kubernetes/pull/73518

xychu on 2 Feb 2019

The kubemark scripts should be fixed in #73746

./cluster/kubemark/*
./test/kubemark/*

mrbobbytables on 6 Feb 2019

I'll work towards fixing everything under ./test/cmd/* next.

mrbobbytables on 7 Feb 2019

Fix

./pkg/kubectl/cmd/edit/testdata/record_testcase.sh
./pkg/util/verify-util-pkg.sh
./plugin/pkg/admission/imagepolicy/gencerts.sh

in https://github.com/kubernetes/kubernetes/pull/73914

danielqsj on 11 Feb 2019

Woops, somehow overlooked that @xychu was tackling ./test/cmd/*.

mrbobbytables on 11 Feb 2019

I've updated the tracking list in the original post with every merged PR up to https://github.com/kubernetes/kubernetes/pull/73213 (the most recent currently) AFAICT. 45 / 283 merged currently :sweat_smile:

BenTheElder on 11 Feb 2019

I will tackle test/images/* next.

mrbobbytables on 16 Feb 2019

./third_party/* should be fixed in #74180

mrbobbytables on 18 Feb 2019

fix cluster/addons/fluentd-elasticsearch/fl……uentd-es-image/run.sh at #74187

xichengliudui on 18 Feb 2019

./cluster/gce/delete-stranded-load-balancers.sh
./cluster/images/etcd-empty-dir-cleanup/etcd-empty-dir-cleanup.sh

in #74192

xichengliudui on 18 Feb 2019

./test/kubemark/pre-existing/util.sh
./test/kubemark/configure-kubectl.sh
./test/integration/ipamperf/test-performance.sh
./test/integration/scheduler_perf/test-performance.sh

in #74193

xichengliudui on 18 Feb 2019

./hack/verify-test-images.sh
./hack/verify-test-owners.sh
./hack/verify-typecheck.sh

in #74451

xichengliudui on 18 Feb 2019

I'll do hack/lib/util.sh next.

ipuustin on 18 Feb 2019

./cluster/kube-down.sh
./cluster/kube-up.sh
./cluster/kube-util.sh
./cluster/kubeadm.sh
./cluster/kubectl.sh

in #74228

xichengliudui on 19 Feb 2019

./hack/e2e-internal/e2e-cluster-size.sh
./hack/e2e-internal/e2e-down.sh
./hack/e2e-internal/e2e-grow-cluster.sh
./hack/e2e-internal/e2e-shrink-cluster.sh
./hack/e2e-internal/e2e-status.sh
./hack/e2e-internal/e2e-up.sh
./hack/e2e-node-test.sh

in #74230

xichengliudui on 19 Feb 2019

./hack/make-rules/build.sh
./hack/make-rules/cross.sh
./hack/make-rules/make-help.sh
./hack/make-rules/test-cmd.sh
./hack/make-rules/test-integration.sh
./hack/make-rules/test-kubeadm-cmd.sh

in #74242

xichengliudui on 19 Feb 2019

Releasing a diff (https://github.com/kubernetes/kubernetes/pull/74259) with fixes for the following :)

hack/verify-bazel.sh
hack/verify-godep-licenses.sh
hack/verify-godeps.sh
hack/verify-gofmt.sh
hack/verify-imports.sh

Thanks for leading efforts to tackle this @BenTheElder :)

mattjmcnaughton on 19 Feb 2019

/reopen
unintentionally closed by #74193

mrbobbytables on 19 Feb 2019

@mrbobbytables: Reopened this issue.

In response to this:

/reopen
unintentionally closed by #74193

k8s-ci-robot on 19 Feb 2019

For those working on the the shellcheck issues, please do not put "fixes #72956" in your PR. This is an umbrella issue for tracking that shouldn't be closed until all the shellcheck issues are resolved.

mrbobbytables on 19 Feb 2019

👍2

I'm sorry @mrbobbytables , I'll take care of it

xichengliudui on 20 Feb 2019

@BenTheElder There may be many files that have been repaired or are under approval. Could you please update the files to be repaired in issue? This will be more convenient! thanks

xichengliudui on 20 Feb 2019

The following scripts fixed by #74299

hack/benchmark-go.sh
hack/verify-all.sh
hack/build-cross.sh
hack/update-all.sh
hack/test-go.sh
hack/build-go.sh

SataQiu on 20 Feb 2019

I tried to update some of the entries but it's relatively manual stuff to verify, and I had to wave off eventually for other work

spiffxp on 20 Feb 2019

I had previously called ./cluster/gce/, but I haven't had much time to work on this. There are a lot there, so don't let me block anyone from taking those on

phenixblue on 20 Feb 2019

Putting out a diff (https://github.com/kubernetes/kubernetes/pull/74332) for the following rn:

hack/godep-restore.sh
hack/godep-save.sh

mattjmcnaughton on 21 Feb 2019

The following scripts fixed by #74333

* hack/list-feature-tests.sh
* hack/verify-govet.sh
* hack/verify-staging-meta-files.sh

SataQiu on 21 Feb 2019

Thanks @spiffxp and thanks all! I updated the checklist in the original post again. 89/284 down (we gained one new file since we started)

BenTheElder on 21 Feb 2019

I addressed all of hack/verify-generated-* in a PR this morning :) Can be found here: https://github.com/kubernetes/kubernetes/pull/74349.

mattjmcnaughton on 21 Feb 2019

❤1

Fixed by #74385

hack/generate-bindata.sh
hack/generate-docs.sh
hack/install-etcd.sh
hack/update-bazel.sh

SataQiu on 22 Feb 2019

❤1

I put out a diff this morning to address the following in hack: https://github.com/kubernetes/kubernetes/pull/74420

hack/verify-linkcheck.sh
hack/verify-pkg-names.sh
hack/verify-spelling.sh
hack/verify-staging-godeps.sh
hack/verify-symbols.sh
hack/verify-test-images.sh
hack/verify-test-owners.sh
hack/verify-typecheck.sh

mattjmcnaughton on 22 Feb 2019

❤1

Fixed by #74455

cluster/gce/gci/node-helper.sh
cluster/update-storage-objects.sh
hack/update-generated-runtime.sh

SataQiu on 23 Feb 2019

If you are looking to take on fixing an item on the list, please remember to go up half-way through this issue and expand the hidden items. There are a lot of comments and PRs of items that people are actively working on that will not show up when searching unless it is expanded.
screen shot 2019-02-23 at 10 45 35 am

mrbobbytables on 23 Feb 2019

❤1 👍1

A bit of advice for those working on this: make it easy on your reviewers. Explain why you're changing what you're changing. "Fixing shellcheck failures" is not enough context.

Some details that could help your reviewer:

what shellcheck failure are you fixing?
why are you doing it this way?
why is this more maintainable than what was there before?
if you need to ignore a shellcheck failure, why? is there some other way of doing things that would accomplish the same goals and _not_ trigger shellcheck?

spiffxp on 23 Feb 2019

👍3

test/images/* should be resolved in #74601

mrbobbytables on 26 Feb 2019

74645

cluster/gce/gci/shutdown.sh
cluster/test-e2e.sh
cluster/test-network.sh

SataQiu on 27 Feb 2019

Hello! Code freeze for 1.14 is coming up in 2 days. Will the work in this issue be implemented in the next week?

soggiest on 7 Mar 2019

Fixed by #75158

hack/lib/golang.sh

k-toyoda-pi on 8 Mar 2019

/milestone v1.15
just moving it for tracking purposes as it's too big - work can continue normally

nikopen on 11 Mar 2019

thanks for moving this, +1 for 1.15, we might actually finish by then :sweat_smile:

BenTheElder on 12 Mar 2019

/reopen

xichengliudui on 1 Apr 2019

👍1

@xichengliudui: Reopened this issue.

In response to this:

/reopen

k8s-ci-robot on 1 Apr 2019

@s-ito-ts please don't use Fixes, use Ref.

xichengliudui on 1 Apr 2019

I list script files which lint failures are not fixed in PRs. Please refer to this.

./build/lib/release.sh
./cluster/clientbin.sh (fix a part of failure in #76152)
./cluster/gce/config-common.sh
./cluster/gce/config-default.sh
./cluster/gce/config-test.sh
./cluster/gce/gci/configure-helper.sh
./cluster/gce/gci/configure.sh
./cluster/gce/gci/flexvolume_node_setup.sh
./cluster/gce/gci/health-monitor.sh
./cluster/gce/gci/master-helper.sh
./cluster/gce/list-resources.sh
./cluster/gce/upgrade-aliases.sh
./cluster/gce/upgrade.sh
./cluster/gce/util.sh
./cluster/restore-from-backup.sh
./hack/cherry_pick_pull.sh
./hack/ginkgo-e2e.sh
./hack/grab-profiles.sh
./hack/lib/init.sh
./hack/lib/swagger.sh
./hack/lib/test.sh
./hack/lib/version.sh
./hack/update-vendor.sh
./hack/verify-import-boss.sh
./hack/verify-no-vendor-cycles.sh
./hack/verify-openapi-spec.sh
./hack/verify-readonly-packages.sh
./hack/verify-test-featuregates.sh
./test/cmd/batch.sh
./test/cmd/certificate.sh
./test/cmd/core.sh
./test/cmd/crd.sh
./test/cmd/create.sh
./test/cmd/diff.sh
./test/cmd/discovery.sh
./test/cmd/generic-resources.sh
./test/cmd/get.sh
./test/cmd/legacy-script.sh
./test/cmd/node-management.sh
./test/cmd/old-print.sh
./test/cmd/proxy.sh
./test/cmd/rbac.sh
./test/cmd/request-timeout.sh
./test/cmd/run.sh
./test/cmd/save-config.sh
./test/e2e_node/conformance/run_test.sh
./test/e2e_node/environment/setup_host.sh
./test/e2e_node/gubernator.sh

k-toyoda-pi on 12 Apr 2019

👍1

The remaining ones in test/images/volumes should be fixed in #74601

test/images/volume/gluster/run_gluster.sh
test/images/volume/iscsi/create_block.sh
test/images/volume/nfs/run_nfs.sh

mrbobbytables on 15 Apr 2019

some files in /hack/make-rules/ were fixed in 2 PRs. could you help to review?

76420

/hack/make-rules/update.sh
/hack/make-rules/verify.sh

75859

/hack/make-rules/clean.sh
/hack/make-rules/test.sh
/hack/make-rules/vet.sh

k-toyoda-pi on 24 Apr 2019

we're getting there! sorry I haven't had time to keep editing that checklist, https://github.com/kubernetes/kubernetes/blob/master/hack/.shellcheck_failures is dwindling!

BenTheElder on 9 May 2019

Hello! We are starting Bug Freeze for 1.15. Is this issue still planned on being incorporated into 1.15?

dstrebel on 30 May 2019

I think optimistically we'll actually finish this in 1.16. there's been
considerable progress but I doubt the remainder will complete before code
freeze...

On Wed, May 29, 2019, 20:51 Dave Strebel notifications@github.com wrote:

Hello! We are starting Bug Freeze for 1.15. Is this issue still planned on
being incorporated into 1.15?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956?email_source=notifications&email_token=AAHADK7BDIWR5EKZA3HIU23PX5FLVA5CNFSM4GQKLPMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRIXIA#issuecomment-497191840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHADK2TA2OSNWG52PXYXSDPX5FLVANCNFSM4GQKLPMA
.

BenTheElder on 30 May 2019

/milestone v1.16

dstrebel on 1 Jun 2019

we're getting close! some of the remaining ones are pretty gnarly though :-)

BenTheElder on 26 Jun 2019

On Tue, Jun 25, 2019 at 10:23:48PM -0700, Benjamin Elder wrote:

we're getting close! some of the remaining ones are pretty gnarly though :-)

--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kubernetes/kubernetes/issues/72956#issuecomment-505723046

Great work leading this :) Thank you for your work!!

mattjmcnaughton on 26 Jun 2019

I updated the checklist since that felt nice but stopped trying to track every single PR mapped to it 😅

Super close :-)

BenTheElder on 28 Jun 2019

I don't think we'll make 1.16, I've not had quite as much time to work on these and some of the remaining ones are ... challenging. We're down to only 24 files though!

BenTheElder on 25 Jul 2019

❤2

On Thu, Jul 25, 2019 at 12:30:04AM -0700, Benjamin Elder wrote:

I don't think we'll make 1.16, I've not had quite as much time to work on these and some of the remaining ones are ... challenging. We're down to only 24 files though!

--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kubernetes/kubernetes/issues/72956#issuecomment-514931006

Wow, fantastic work to only have 24 files to go :)

mattjmcnaughton on 25 Jul 2019

I created PRs fix the following script files. Could someone review PRs?

./cluster/gce/gci/flexvolume_node_setup.sh #81061
./cluster/test-e2e.sh #80971
./test/images/image-util.sh #80742

k-toyoda-pi on 7 Aug 2019

❤1 👍1

Trying to get back on this.

PR #81882 submitted for hack/lib/test.sh

phenixblue on 24 Aug 2019

Could you please review PRs?

validate-cluster.sh #81345
image-util.sh #80742

k-toyoda-pi on 27 Aug 2019

Hi, I'm spending this afternoon catching up on PR review and my inbox
currently.... I will get to these.

On Mon, Aug 26, 2019 at 4:33 PM Kohei Toyoda notifications@github.com
wrote:

Could you please review PRs?

validate-cluster.sh #81345
https://github.com/kubernetes/kubernetes/pull/81345

image-util.sh #80742
https://github.com/kubernetes/kubernetes/pull/80742

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956?email_source=notifications&email_token=AAHADK7I6N5BJPMAG2XHOTLQGRR5NA5CNFSM4GQKLPMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5F7SDY#issuecomment-525072655,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHADK4BZSJHYSQ7ZCXNUITQGRR5NANCNFSM4GQKLPMA
.

BenTheElder on 27 Aug 2019

In the future please add me to the PR (/cc @BenTheElder for review, /assign @BenTheElder for approval if it's reviewed and I am an OWNER of the relevant files).

I use https://gubernator.k8s.io/pr to monitor incoming PRs, those PRs seem to be assigned to others (who are not responding :()

BenTheElder on 27 Aug 2019

👍2

Hello! I'm part of the bug triage team for the 1.16 release cycle and considering this issue is tagged for 1.16, but not updated for a long time, I'd like to check its status. The code freeze is starting on August 29th which means that there should be a PR ready (and merged) until then.

Do we still target this issue to be fixed for 1.16? If not please re-tag the issue to the planned milestone.

Pothulapati on 28 Aug 2019

It's really close but going to be 1.17.
I don't believe I have permission to change milestones, or I would have
already.

On Wed, Aug 28, 2019, 06:44 Tarun Pothulapati notifications@github.com
wrote:

Hello! I'm part of the bug triage team for the 1.16 release cycle and
considering this issue is tagged for 1.16, but not updated for a long time,
I'd like to check its status. The code freeze is starting on August 29th
which means that there should be a PR ready (and merged) until then.

Do we still target this issue to be fixed for 1.16? If not please re-tag
the issue to the planned milestone.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956?email_source=notifications&email_token=AAHADK6I5MGAGUOGVSQLBITQGZ6L5A5CNFSM4GQKLPMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LFCCQ#issuecomment-525750538,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHADKZ2UVXOFVEG35CKFTLQGZ6L5ANCNFSM4GQKLPMA
.

BenTheElder on 28 Aug 2019

/milestone v1.17

liggitt on 31 Aug 2019

@BenTheElder:
I want help.
let me work on thses files:

./build/lib/release.sh
./cluster/common.sh
./cluster/gce/config-common.sh

beautytiger on 4 Sep 2019

I will fix
./cluster/gce/gci/configure.sh

YuikoTakada on 26 Sep 2019

Hi @BenTheElder

Bug Triage Release Team checking in. Code freeze for the 1.17 release is on November 14. Is this still intended for 1.17? Thanks!

kikisdeliveryservice on 26 Oct 2019

This will go into 1.18 most likely. We have some new issues to fix with the
next version of shellcheck WIP.

On Sat, Oct 26, 2019, 11:56 Kirsten notifications@github.com wrote:

Hi @BenTheElder https://github.com/BenTheElder

Bug Triage Release Team checking in. Code freeze for the 1.17 release is
on November 18. Is this still intended for 1.17? Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956?email_source=notifications&email_token=AAHADK65MQNWSORQIGTS2G3QQSHFBA5CNFSM4GQKLPMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKOQUQ#issuecomment-546629714,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHADK2KHAWZDEJCKZP2LCTQQSHFBANCNFSM4GQKLPMA
.

BenTheElder on 26 Oct 2019

👍1

@josiahbjorgaard: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.13, v1.14, v1.15, v1.16, v1.17, v1.18, v1.19, v2.0]

Use /milestone clear to clear the milestone.

In response to this:

/milestone next

k8s-ci-robot on 3 Nov 2019

/milestone v1.18

josiahbjorgaard on 3 Nov 2019

@BenTheElder:
I want help.
let me work on thses files:
./build/lib/release.sh
./cluster/common.sh
./cluster/gce/config-common.sh

What is the current status of these? The first two of those files are still found in hack/.shellcheck_failures, but perhaps there are fixes coming in? Or would you like a wingman on this?

joakimr-axis on 16 Jan 2020

Suggestion for fixing ./build/lib/release.sh found in https://github.com/kubernetes/kubernetes/pull/87285

joakimr-axis on 16 Jan 2020

Hi, most of these have some attempts to patch them in flight but they've been tricky to land (between some awkward failures, and getting review :/) and tend to be somewhat stalled ... :disappointed:
I can't approve some of the changes yet (cluster/), but I will happily find time to review PRs.

BenTheElder on 16 Jan 2020

Hello @BenTheElder !
Bug Triage team here for the 1.18 release. This is a friendly reminder that code freeze is scheduled for 5 March. Is this issue still intended for milestone 1.18, or should it extend to the next one? Thanks in advance!

gianarb on 12 Feb 2020

we'll have to punt this one again, we have made a little progress but it's getting harder to get approvals on the remaining files (I can't approve these :(). I would guess we need at least 1.19 if not 1.20 to finish.

BenTheElder on 14 Feb 2020

Hello @BenTheElder thanks for your response. I will move this to 1.19 for now.
Have a good day

/milestone v1.19

gianarb on 19 Feb 2020

updated the checklist, 9 to go! have a PR out for one of them https://github.com/kubernetes/kubernetes/pull/88349

BenTheElder on 19 Feb 2020

updated the checklist, 9 to go! have a PR out for one of them #88349

@k-toyoda-pi has https://github.com/kubernetes/kubernetes/pull/82059 for cluster/pre-existing/util.sh which seems to be stranded since November?

joakimr-axis on 24 Feb 2020

We've gained a new cluster/ approver or two since then, I'll drop a note
and see if we can get that approved finally ...

On Mon, Feb 24, 2020, 01:41 Joakim Roubert notifications@github.com wrote:

updated the checklist, 9 to go! have a PR out for one of them #88349
https://github.com/kubernetes/kubernetes/pull/88349

@k-toyoda-pi https://github.com/k-toyoda-pi has #82059
https://github.com/kubernetes/kubernetes/pull/82059 for
cluster/pre-existing/util.sh which seems to be stranded since November?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956?email_source=notifications&email_token=AAHADK2AGTVIVK72R2UVJ33REOI3VA5CNFSM4GQKLPMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXE36I#issuecomment-590237177,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHADK7SVYUCF4PVFA4CKYTREOI3VANCNFSM4GQKLPMA
.

BenTheElder on 24 Feb 2020

👍1

We've gained a new cluster/ approver or two since then, I'll drop a note and see if we can get that approved finally ...

Awesome!

joakimr-axis on 24 Feb 2020

Searching the comments here, and the section for currently open PRs, it seems these files are remaining as not currently having either a PR or someone who claimed it?

./cluster/gce/config-test.sh
./cluster/gce/gci/configure-helper.sh
./cluster/gce/gci/master-helper.sh
./cluster/gce/upgrade.sh

joakimr-axis on 24 Feb 2020

Created a stab at cluster/gce/config-test.sh in https://github.com/kubernetes/kubernetes/pull/88459.

joakimr-axis on 25 Feb 2020

@joakimr-axis
Can I take some of them?
./cluster/gce/gci/master-helper.sh
./cluster/gce/upgrade.sh

gavinfish on 26 Feb 2020

@joakimr-axis
Can I take some of them?
./cluster/gce/gci/master-helper.sh
./cluster/gce/upgrade.sh

That would be a question for the admins, I guess, but as for me, I am not working on those.

joakimr-axis on 26 Feb 2020

anyone is free to work on anything, PRs welcome 😅

the question will just be getting them in. I apologize for my own review
latency these days, have a bit too much going on.

On Wed, Feb 26, 2020 at 12:59 AM Joakim Roubert notifications@github.com
wrote:

@joakimr-axis https://github.com/joakimr-axis
Can I take some of them?
./cluster/gce/gci/master-helper.sh
./cluster/gce/upgrade.sh

That would be a question for the admins, I guess, but as for me, I am not
working on those.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/72956?email_source=notifications&email_token=AAHADK2QWEULE6K73OCIHWDREYVPHA5CNFSM4GQKLPMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM7LTVQ#issuecomment-591313366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHADKZNXX6HV4E7PLQSF7DREYVPHANCNFSM4GQKLPMA
.

BenTheElder on 27 Feb 2020

👍1

Created a stab at cluster/gce/config-test.sh in #88459.

...where now all tests have passed.

joakimr-axis on 28 Feb 2020

Suggestion for fixing for cluster/gce/util.sh in PR #90405.

joakimr-axis on 23 Apr 2020

I do believe there is now actions going on for all remaining files in hack/.shellcheck_failures:

./cluster/gce/gci/configure-helper.sh #90433
./cluster/gce/gci/configure.sh #90442
./cluster/gce/gci/master-helper.sh #88582 (needs rebase, owner @gavinfish)
./cluster/gce/util.sh #90405
./cluster/log-dump/log-dump.sh #88349

joakimr-axis on 24 Apr 2020

❤1 👍1

/milestone v1.20
I don't think we're quite going to hit 1.19 and that's OK.

Sorry I've become ~inactive here, I've gained more duties and we're struggling with test health right now, I don't expect much time for this myself this release.

BenTheElder on 14 Jun 2020

👍2

Updated the checklist, rebasing a PR I have open for log-dump.sh

BenTheElder on 22 Jun 2020

👍1

Updated the checklist, rebasing a PR I have open for log-dump.sh

It sure is pretty close now!

joakimr-axis on 23 Jun 2020

❤1

Closing in now, log-dump.sh seems to be almost in. Current status of remaining files:

./cluster/gce/gci/configure.sh #90442
./cluster/gce/gci/master-helper.sh #88582 (needs rebase, owner @gavinfish, _now stale due to inactivity_)
./cluster/gce/util.sh #90405
./cluster/log-dump/log-dump.sh #88349

joakimr-axis on 28 Aug 2020

❤1

log-dump.sh is now merged. Remaining:

./cluster/gce/gci/configure.sh #90442
./cluster/gce/gci/master-helper.sh #88582 (needs rebase, owner @gavinfish, now stale due to inactivity)
./cluster/gce/util.sh #90405

joakimr-axis on 2 Sep 2020

The PR for cluster/gce/util.sh #90405 is very large (since there are many things that need to be fixed in it).
When the (big) size of it was mentioned, I suggested it might perhaps be split into a couple of sub-PRs, but there has been no input regarding that yet. What do you guys think about that?

joakimr-axis on 2 Sep 2020

+1, let's try breaking it up a little. Sorry for the lack of input ("queue" gets long sometimes) and thank you for working on this!

BenTheElder on 3 Sep 2020

👍1

+1, let's try breaking it up a little.

Very good, I'll give it a shot and see if I can group it into some good way.

("queue" gets long sometimes)

:-D

joakimr-axis on 3 Sep 2020

90405's sub-PR #94458 has now been approved.

joakimr-axis on 3 Sep 2020

Hey :wave: Bug Triage here. Wanted to follow up on the status of this issue as we're approaching code freeze on 12.11.2020. This issue is tagged for 1.20, is it still planned for this release?

MonzElmasry on 26 Oct 2020

Current status is (still) 3 remaining (although a handful of the sub-PRs for cluster/gce/util.sh have been merged):

./cluster/gce/gci/configure.sh #90442 (all tests passed, ready for jay or nay)
./cluster/gce/gci/master-helper.sh #88582 _(closed due to inactivity!)_
./cluster/gce/util.sh #90405 (has sub-PRs #94456 #94459 #94463 breaking up all the changes into smaller pieces easier to handle)

joakimr-axis on 26 Oct 2020

I have now created #95865 which is bringing @gavinfish's closed-due-to-inactivity #88582 back to life with a few updates. With that one, the lineup of active ongoings would look like:

./cluster/gce/gci/configure.sh #90442 (all tests passed, ready for jay or nay)
./cluster/gce/gci/master-helper.sh #95865
./cluster/gce/util.sh #90405 (has sub-PRs #94456 #94459 #94463 breaking up all the changes into smaller pieces easier to handle)

joakimr-axis on 26 Oct 2020

👋 Hi, Bug Triage here, we're pretty late into the code freeze for 1.20 - I am going to put this in the 1.21 milestone

/milestone v1.21