Kubernetes-client: KubernetesDeserializer registration for CustomResources broken

[Fabian-K]

The current implementation in CustomResourceOperationsImpl passes the wrong apiVersion and Kind values to KubernetesDeserializer.registerCustomKind(...).

apiVersion and Kind for a CustomResourceDefinition are always apiextensions/v1beta1 and CustomResourceDefinition.

The values from the spec needs to be passed for registering the custom kind in the deserializer.

[bbeaudreault]

Would it be possible to get this fix included in a release? I tried upgrading to 4.9.0 and this is causing issues.

[rohanKanojia]

@manusa @oscerd : thoughts?? Shall we cut a minor release 4.9.1 or shall we proceed towards major 5.0.0 release?

[oscerd]

4.9.1 I guess

[bbeaudreault]

Thanks both! 4.9.1 would be appreciated. Looks like there have been a few bug fixes in the last month.

[manusa]

I think the only breaking changes as of now in master are the model upgrades for Tekton and Knative. Not sure how you usually proceed with this situations.

I don't mind releasing now and after the split. Regarding version numbering, whatever we usually do for similar cases (the project is quite lenient regarding semver).

It's also a good idea cutting a release before the split merge (there are 77 commits since last release) and many bugfixes.

[rohanKanojia]

@bbeaudreault : We have released v4.9.1 . Could you please try it out and share feedback?

[bbeaudreault]

Thanks for getting that out! I was able to pull it into my project and tests are now passing. If I run into any other issues, I'll let you know.