Kubernetes-client: CertUtils.getInputStreamFromDataOrFile wrong parameter order

Created on 9 Sep 2019  路  7Comments  路  Source: fabric8io/kubernetes-client

In https://github.com/fabric8io/kubernetes-client/blob/8072213af9f04132eb27169472dd239f2b21ca3e/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Config.java#L679 the function getInputStreamFromDataOrFile is called with parameters file and data, but the function expects it the other way around: https://github.com/fabric8io/kubernetes-client/blob/8072213af9f04132eb27169472dd239f2b21ca3e/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/internal/CertUtils.java#L59

picture kesyu

Most helpful comment

You need to fork the repository, create the branch on your fork and then open a PR against the original one.

picture oscerd on 9 Sep 2019
👍2

All 7 comments

@kesyu : oh, Could you please raise a quick PR to fix this?

rohanKanojia picture rohanKanojia on 9 Sep 2019

Sure

kesyu picture kesyu on 9 Sep 2019
👍1

@kesyu : much appreciated, Thanks.

rohanKanojia picture rohanKanojia on 9 Sep 2019

@rohanKanojia Can't raise the PR, I only have read permission to the repository.

kesyu picture kesyu on 9 Sep 2019

You need to fork the repository, create the branch on your fork and then open a PR against the original one.

oscerd picture oscerd on 9 Sep 2019
👍2

@oscerd Ah, I see, thanks.

kesyu picture kesyu on 9 Sep 2019

closed via #1747

rohanKanojia picture rohanKanojia on 25 Sep 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

if6was9 picture if6was9  路  5Comments
FWiesner picture FWiesner  路  4Comments
yangjinlogic picture yangjinlogic  路  4Comments
skabashnyuk picture skabashnyuk  路  4Comments
antonalechnovic picture antonalechnovic  路  5Comments