Kubebuilder: Use annotations to control additional printer columns

[deedubs]

Using the same technique as annotations we should be able to allow specifying the attributes we want to include in the cli when printing to console

Initially proposed here by @mheese

[deedubs]

Looks like this will be done over in controller-tools

[droot]

Yes, I will be super useful feature from UX perspective. Happy to review/guide if someone wants to make a PR for this.

[deedubs]

@droot sign me up!!

[deedubs]

I was thinking about a annotation format like:
+kubebuilder:print:type=<type>,description=<desc>,JSONPath:<.spec.Name>?priority=<0|1>,?format=<format>

[droot]

Thanks for working on it.
Minor suggestion about the format:

• May be call the annotation +kubebuilder:printcolumn to make it more explicit
• Since each columns require 4 fields (name, spec, ...etc), it can get very verbose, so packing all columns in one line may not be great UX. So we should allow multiple lines with one line for each column.

[droot]

@deedubs Were you able to make any progress on it ? (or is it available for someone to pick up ?)

[deedubs]

Available to pickup

Dan Williams

On Wed, Nov 7, 2018, 4:27 PM Sunil Arora <[email protected] wrote:

@deedubs https://github.com/deedubs Were you able to make any progress
on it ? (or is it available for someone to pick up ?)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/kubebuilder/issues/447#issuecomment-436783575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAnU5-yOIr94VzZxu8EBSpmVaaJPGkTks5us1BfgaJpZM4Xj1Ll
.

[sohankunkerkar]

@droot I can give it a shot.

[droot]

Thanks for signing up. Assigning it to you soon, hack it away :) ping me on
slack if you need any help.

On Fri, Nov 16, 2018, 8:18 AM Sohan Kunkerkar <[email protected]
wrote:

@droot https://github.com/droot I can give it a shot.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/kubebuilder/issues/447#issuecomment-439445088,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKf_dQ_7txyc2R3tlNYzbybVxOL1EDdks5uvuVXgaJpZM4Xj1Ll
.

[droot]

/assign @sohankunkerkar

[k8s-ci-robot]

@droot: GitHub didn't allow me to assign the following users: sohankunkerkar.

Note that only kubernetes-sigs members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @sohankunkerkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[droot]

@sohankunkerkar consider this issue assigned to you. I am not able to assign you because of the reason mentioned in previous message by the bot.

[sohankunkerkar]

yeah @droot

[sohankunkerkar]

Thanks for signing up. Assigning it to you soon, hack it away :) ping me on slack if you need any help.
…
On Fri, Nov 16, 2018, 8:18 AM Sohan Kunkerkar @.* wrote: @droot https://github.com/droot I can give it a shot. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#447 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKf_dQ_7txyc2R3tlNYzbybVxOL1EDdks5uvuVXgaJpZM4Xj1Ll .

Sure thing!