Kubebuilder: GOPATH is a multi-value environment variable

[abdennour]

I see you catch an error by this message:

2018/06/22 23:28:20 kubebuilder must be run from the project root under $GOPATH/src/package.

When GOPATH=/Users/abd/go, it works. and when GOPATH=/Users/abd/v1/go:/Users/abd/v2/go, it does not work.

I assume you didn't consider the multi-value aspect of GOPATH.

Indeed, you can append multiple values to GOPATH by separating them through :.

[surbas]

I ran into the same issue. I have taken a look at the code and I may be wrong but seems like an easy change to accommodate multiple directories in GOPATH. @pwittrock @Liujingfang1 would this be a valid issue to fix? Is there more to it? I would like to take it on myself.

[abdennour]

Great @surbas ! Please go ahead.

[pwittrock]

@surbas SGTM. Please tae it on.

[surbas]

Will do! Will try to have a pull by end of weekend.

On Mon, Jul 9, 2018 at 9:11 PM Phillip Wittrock [e-mail]
wrote:

@surbas https://github.com/surbas SGTM. Please tae it on.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/kubebuilder/issues/285#issuecomment-403667216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaK53Zt5B517pXLdaqHdsJS0aXQtQqGks5uE_8kgaJpZM4U0aY9
.

[fanzhangio]

@surbas. Thanks for your help. Please let me know if you need any help.

[FogDong]

Same issue😢, have you finished your PR? 😉@surbas

[luisdavim]

any updates on this one?

[luisdavim]

This is actually covered in https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/crd/util/util.go maybe we can use that.

[luisdavim]

I've opened a PR to address this issue, please let me know what you think.