Kubeadm: checks_windows: wrap errors properly

Created on 7 Mar 2020 · 4Comments · Source: kubernetes/kubeadm

while @benmoss was testing kubeadm on Windows he noticed that kubeadm is ignoring some underlying errors in this code:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/preflight/checks_windows.go#L32-L50

/help
/good-first-issue
/kind cleanup
/priority backlog

send a PR to replace:
errors.New("some message")

on these two lines:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/preflight/checks_windows.go#L35
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/preflight/checks_windows.go#L40

with:
errors.Wrap(err, "some message")

NOTE we are in code freeze for 1.18 and the PR can only be merged after March 17th.

good first issue help wanted kincleanup lifecyclactive prioritbacklog

Source

neolit123

All 4 comments

@neolit123:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

while @benmoss was testing kubeadm on Windows he noticed that kubeadm is ignoring some underlying errors in this code:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/preflight/checks_windows.go#L32-L50

/help
/good-first-issue
/kind cleanup
/priority backlog

send a PR to replace:
errors.New("some message")

on these two lines:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/preflight/checks_windows.go#L35
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/preflight/checks_windows.go#L40

with:
errors.Wrap(err, "some message")

NOTE we are in code freeze for 1.18 and the PR can only be merged after March 17th.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.