Kubeadm: cleanup: master -> control-plane

Created on 31 Jan 2019 · 10Comments · Source: kubernetes/kubeadm

we still have a lot of places in user visible output and in the code base where "master" is used.
we should be using "control-plane/Control Plane/controlPlane" in all possible locations.

guide:

clone the kubernetes/kubernetes repository
cd the folder ./cmd/kubeadm and use grep to search for the word master / Master etc...
replace occurrences of "master" with "control plane" and send PR.
if there are way too many changes, send multiple PRs.

thanks.

good first issue help wanted kincleanup kindocumentation lifecyclactive prioritimportant-longterm

Source

neolit123

Most helpful comment

this can be closed for now after the help and a number of PRs from @vanduc95 and @SataQiu
thank you! :tada:

neolit123 on 28 Feb 2019

🎉3 👍1

All 10 comments

@neolit123 I will work on it

vanduc95 on 31 Jan 2019

ohh, @atoato88, I am new k8s, would you mind if I take this?

vanduc95 on 31 Jan 2019

Thanks @vanduc95
/lifecycle active

yagonobre on 31 Jan 2019

@vanduc95 It's OK for me.
Sorry for unclear action to this issue.
I should have said "I do this" at here.
If you create PR, can I review it, OK?

atoato88 on 31 Jan 2019

👍1

@atoato88 yes, thanks.

vanduc95 on 31 Jan 2019

👍1

@vanduc95 are you working on this?

RA489 on 4 Feb 2019

@RA489, I am on Lunar new year holiday, I will working on this after the end of holiday.

vanduc95 on 5 Feb 2019

👍1

Hey @vanduc95 and @SataQiu I saw that both are working in the same issue, can you coordinating to avoid duplicated work? In general a issue with the label lifecycle/active means that someone is currently working on it.

yagonobre on 13 Feb 2019

@yagonobre Thank you for your reminding. I'm sorry that I didn't notice the lifecycle/active label.
@vanduc95 As the task has been assigned to you, I will not work in this issue more. Please go on with your work. Good luck!