We need to update limit defaults and make certain we are using sane values for priorities. We have legacy cruft that also needs to be audited.
This is spreading, even if with small variants:
https://github.com/kubernetes/kubernetes/pull/72424 (control plane components- resouce request & QoS/PriorityClass)
https://github.com/kubernetes/kubeadm/issues/1095 (control plane components - resouce request)
https://github.com/kubernetes/kubeadm/issues/1337 (core DNS - QoS/PriorityClass)
I can work on this
/lifecycle active
/assign
@yagonobre fyi there is also https://github.com/kubernetes/kubernetes/pull/73649
needs
priorityClassName: system-cluster-critical
and remove older field (TBD)
@yagonobre as per our discussion today, are you OK with me having a look at this?
Certainly, we were using scheduler.alpha.kubernetes.io/critical-pod annotation. priorityClassName is already set to system-cluster-critical on all control plane components. I will audit everything to remove the old annotation.
@ereslibre go ahead :)
/unassign
IMO we should add request/limit too.