Kubeadm: Fix some names of tests in phases/controlplane/manifests_test.go

[atoato88]

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

Versions

kubeadm version (use kubeadm version):
I found this in code reading on k/k master. So I don't use any kubeadm binary.

Environment:

• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Others:

What happened?

Following test name have "custom cloudprovider" in name, but it checks for "--cluster-cidr" in kube-controller-manager parameter.

• https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/controlplane/manifests_test.go#L600
• https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/controlplane/manifests_test.go#L703

It should rename from "custom cloudprovider" to "custom cluster-cidr" or "custom pod-subnet", I think.

What you expected to happen?

NONE

How to reproduce it (as minimally and precisely as possible)?

NONE

Anything else we need to know?

NONE

[neolit123]

i don't think this is that much of an error, because the CP can be using a custom CIDR too.
but if someone wants to fix, PRs are welcome.

please mind that it can be merged only after the release of 1.13. thanks.

[yuexiao-wang]

I will work on it

[k8s-ci-robot]

@yuexiao-wang: GitHub didn't allow me to assign the following users: yuexiao-wang.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yagonobre]

Thanks @yuexiao-wang
/lifecycle active

[yuexiao-wang]

PR has merged and this issue should be closed

[yagonobre]

Thanks again
/close

[k8s-ci-robot]

@yagonobre: Closing this issue.

In response to this:

Thanks again
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yuexiao-wang]

Thanks