Kubeadm: Change FetchConfigFromFileOrCluster parameters to improve cmd upgrade, join and reset tests
Is this a BUG REPORT or FEATURE REQUEST?
Choose one: FEATURE REQUEST
What happened?
configutil.FetchConfigFromFileOrCluster and configutil.loadInitConfigurationFromFileuse the constants.KubernetesDir
What you expected to happen?
Make KubernetesDir a parameter in both so we can mock this on upgrade, join ad reset command tests.
yagonobre
All 11 comments
@timothysc I'll work on that
yagonobre
on 26 Oct 2018
/lifecycle active
thanks @yagonobre
neolit123
on 26 Oct 2018
/assign
yagonobre
on 29 Nov 2018
@neolit123 i think we can close this right?
MalloZup
on 12 Dec 2018
i don't think we can yet.
neolit123
on 12 Dec 2018
@yagonobre I am actually doing some experimental work in that field, trying to share more code between InitConfiguration funcs, optimize stuff a bit and reduce the unnecessary usage of InitConfiguration.
So, on my side, I reduced the calls to this func to a single one and largely got it replaced by a func, that has almost the same signature, but fetches config solely from the cluster.
rosti
on 12 Dec 2018
Thanks @rosti, I was off in the last 2 week due to kubecon, I'll take a look at this in a bit.
yagonobre
on 23 Dec 2018
can we close this @rosti ,@yagonobre ?
neolit123
on 3 Feb 2019
@neolit123 unfortunately not, I'll have a pr this week.
yagonobre
on 5 Feb 2019
Move to 1.15
yagonobre
on 5 Mar 2019
Move to 1.15
done.
neolit123
on 6 Mar 2019
Related issues
mlevesquedion
路
3Comments
kvaps
路
3Comments
tmjd
路
4Comments
ggaaooppeenngg
路
4Comments
andersla
路
4Comments
Most helpful comment
@yagonobre I am actually doing some experimental work in that field, trying to share more code between InitConfiguration funcs, optimize stuff a bit and reduce the unnecessary usage of InitConfiguration.
So, on my side, I reduced the calls to this func to a single one and largely got it replaced by a func, that has almost the same signature, but fetches config solely from the cluster.