Kubeadm: Warning on docker version during preflights is wrong

[chuckha]

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

Versions

kubeadm version (use kubeadm version): v1.12.0-rc.1

docker version: 17.03.3-ce

What happened?

When running kubeadm init the preflight check says:

        [WARNING SystemVerification]: docker version is greater than the most recently validated version. Docker version: 17.03.3-ce. Max validated version: 18.06

What you expected to happen?

I expected it to to not warn or to tell me it's less than the most recently validated version, not greater than.

How to reproduce it (as minimally and precisely as possible)?

• Install docker 17.03
• set up a kubelet with v1.12.0-rc.1 or later
• run kubeadm init with v1.12.0-rc.1 or later

Anything else we need to know?

This is a non urgent bug and it's a good first issue so I'm assigning it to @carlisia.

[dims]

/good-first-issue

[k8s-ci-robot]

@dims:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timothysc]

@neolit123 does this even exist now with your last PR fix for 18.06?

[neolit123]

@timothysc
yep, i modified the message as it was incorrect.

right now it indicates that the tested version is not in the list of versions that are known to work:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/system/docker_validator.go#L81-L83

/close

[k8s-ci-robot]

@neolit123: Closing this issue.

In response to this:

@timothysc
yep, i modified the message as it was incorrect.

right now it indicates that the tested version is not in the list of versions that are known to work:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/util/system/docker_validator.go#L81-L83

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

@carlisia, @chuckha sorry we had to fix that as it was urgent for 1.12. :)

[carlisia]

No worries, thank you for letting me know! I was going to do it quickly, then got build failures when I first built k8s, so was waiting for the weekend to dig deeper. Glad it's taken care of 👍