As discussed in https://github.com/kubernetes/kube-state-metrics/issues/854 and offline we want to have only specific annotation metrics, we mentioned those good candidates for now are:
• deployment revision
• ingress class
This issue is to discuss the design and what we want to include in the metric, etc. There were a couple of ideas in the above-mentioned issue.
Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
I also want to point out that the higher significance and importance of these fields, the lesser the justification of these fields to be actually exposed as annotations. I think we must be mindful of this as well and redirect the question to the k8s.io/api folks when appropriate.
+1 another usecase:
Use kube-state-metrics' kube_pod_container_status_restarts_total for alerting frequent container-restarts *) and use annotations to route to the correct team in alert-manager. Annotations can contain characters which label values cannot:
I don't see why this is any more problematic than the kube_pod_labels metric, especially as an opt-in metric/feature.
*)
(increase(kube_pod_container_status_restarts_total[1h]) > 5) * on (namespace, pod) group_left(label_my_org_com_opsgenieteam) kube_pod_labels
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
+1 another usecase:
Use kube-state-metrics' kube_pod_container_status_restarts_total for alerting frequent container-restarts *) and use annotations to route to the correct team in alert-manager. Annotations can contain characters which label values cannot:
I don't see why this is any more problematic than the kube_pod_labels metric, especially as an opt-in metric/feature.
*)