Kube-router: NetworkPolicy: Support including both podSelector and namespaceSelector in a NetworkPolicyPeer

Created on 29 Jun 2018  路  4Comments  路  Source: cloudnativelabs/kube-router

Hi,

Kubernetes 1.11 allows including both podSelector and namespaceSelector in a NetworkPolicyPeer (see PR https://github.com/kubernetes/kubernetes/pull/60452 and issue https://github.com/kubernetes/kubernetes/issues/58637).

Are there any changes required in kube-router to support this?

Most helpful comment

LGTM

All 4 comments

Yes, changes are required.

The network_policy_controller currently assumes that the policy peers have _either_ namespaceSelector or podSelector. I'm working on a PR.

@murali-reddy @voidengineer When you have time, let me know what you think of: https://github.com/cloudnativelabs/kube-router/pull/479

LGTM

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zerkms picture zerkms  路  3Comments

Daryltp picture Daryltp  路  6Comments

leandromoreira picture leandromoreira  路  9Comments

rmb938 picture rmb938  路  6Comments

sepich picture sepich  路  5Comments