Kube-prometheus: Use kube-state-metrics jsonnet dependency

Created on 10 Jan 2020  路  7Comments  路  Source: prometheus-operator/kube-prometheus

As kube-state-metrics now has switched to including jsonnet we should remove ours in favour of that and bring it in as a dependency. Same goes for the alerts.

See https://github.com/coreos/kube-prometheus/pull/368#issuecomment-572694051

help wanted

Most helpful comment

I would like to end up with the similar deployment we already have in this repo just that it uses the upstream jsonnet. In a follow up issue we should look at how to easily opt into the new autosharding feature. Main point of this issue is to remove the ned to manually update the ksm deployments.

All 7 comments

I can submit PR after holidays (beginning of Feb). would it be okay?

If no one will have done it by then, please! :)

Yes go for it! Thanks!

Hi, I had a quick look into the ksm lib on kube-prometheus, it contains additionally ksm autoscaler. Thus, there are 2 possibilities:

  • remove autoscaler and generate sts (which has autosharding) which can replace ksm autoscaler in some way;
  • keep autoscaler and just use standard deployment from kube-state-metrics repo.
    what do you think?
    //cc @brancz
    //cc @LiliC

I think we should default to the standard deployment. We can figure out afterwards how people might be able to opt into the autosharding feature with the statefulset.

I would like to end up with the similar deployment we already have in this repo just that it uses the upstream jsonnet. In a follow up issue we should look at how to easily opt into the new autosharding feature. Main point of this issue is to remove the ned to manually update the ksm deployments.

I think this can be closed now. If we need to do follow up we can open a new issue.

Was this page helpful?
0 / 5 - 0 ratings