Ktor: [ktor-common-client] Custom timeouts

Created on 15 Nov 2018 · 8Comments · Source: ktorio/ktor

Hello guys! I've detected that the timeout feature/option is not available yet in the common ktor client.

Could you please add it?

Thanks!

enhancement up for grabs

Source

sergiocasero

👍19

Most helpful comment

Hi @Syrou, @nehahemnani92, @sergiocasero. Thanks for the report!
It looks like the most cases could be covered by:

withTimeout(...) {
    client.get<Data>(...)
}

What kind of timeout would you like to see?

e5l on 15 Jul 2019

👍2

All 8 comments

@e5l Any news on this? I really need this feature for MPP common client

Syrou on 28 Mar 2019

@e5l Is there a plan to add this enhancement in the near future?

nehahemnani92 on 12 Jul 2019

Hi @Syrou, @nehahemnani92, @sergiocasero. Thanks for the report!
It looks like the most cases could be covered by:

withTimeout(...) {
    client.get<Data>(...)
}

What kind of timeout would you like to see?

e5l on 15 Jul 2019

👍2

Ohh, looks pretty nice @e5l , let me check it because I think that yes, this will cover the 90% of cases.

sergiocasero on 26 Jul 2019

@e5l Pretty sure what I want is to have that ability from the configuration phase. Sure it works setting it on each request/call but I'd want to be able to define a default timeout in the configuration step and then override that by using the withTimeout(...)

Syrou on 27 Jul 2019

See https://github.com/ktorio/ktor/issues/1134#issuecomment-591477101