Krypto-trading-bot: Improvement: Updating orders whenever possible

[Camille92]

Hi Carles and everyone,

I was thinking, why not instead of canceling + creating a new order the bot would not rather update existing orders.

I think this would improve the speed of trading and wouldn't let the market with a few ms without an order.

When we cancel an order we have to wait for the response "order cancelled" to come to K + wait for the fund to be liberated on our account and then send a new order.

I was looking at the API and correct me if I'm wrong but I think that you can update orders in:
Bitfinex, Korbit and HitBTC.

What do you think?

Would that help to trade?

Best,

Camille

[serzhiio]

Thats a great idea, but doesnt we already use orders updating?
And also we can use FOK (Fill or kill) orders type, cant we?
Or at least lets make 0.5-1s GTD (Good till date) orders.
UPD: just tested FOK and IOC its a crap.

[serzhiio]

May be we can get rid of #557 if implement order updating?

[Camille92]

Well I don't think Okex allows for updating orders, but I'm not a pro in API, feel free to check :)

Yes, I was thinking "why would we need FOK? :p"

[ctubio]

yea that is only allowed in some exchanges; and because is not allowed in all exchanges we are not using this functionality.

will attempt to make use of it soOn were possible cos will save one api call

im not sure if makes sense to have a --without-replace arg, so it can be reverted without coding; i think is not needed cos should be transparent this mod

thanks for insist on this'''

[Camille92]

Thanks! :D

[ctubio]

for exchanges that do not support it we can do like Bitfinex and put both msgs into a single websocket msg, but separated by a new line each msg :dancer: (multiline msgs should be supported by default because of the websocket protocol without extra application logic/endpoints; will try'¡1)

for gdax seems not possible no matter what because of FIX protocol; need to investigate how to join 2 FIX msgs into a single api call someday

[ctubio]

for now Bitfinex is nicely done; for the rest of exchanges i will test to join the websocket messages someday :dancer: