Kratos: If the only files changed are python scripts why is necessary to wait for appveyor and travis compilation in a PR ?
josep-m-carbonell
All 4 comments
@roigcarlo
loumalouomega
on 11 Oct 2018
Because travis runs the tests, and python files may very well affect tests passing/not passing.
There were some technical reasons why it was hard to detect if a PR affected only some files/file types (which is why travis always compiles, even if you just change python), but that does not change the main point.
jcotela
on 11 Oct 2018
Good, there is no problem to wait for the compilation, just it is a result that you know in advance. It would be optimal if the system could detect if only python files are modified and run the tests in that case. I guess it must be hard to detect when this happens, as you argued.
josep-m-carbonell
on 11 Oct 2018
As @jcotela said is technically hard. There is no problem per-se into detect that only python files where modified but adding that along with other features that we currently have enabled. In particular the problem is catching, cotire, incremental builds and auto-cancels as well as some filters.
Also I understand the problem and it will be a priority when I set up our machine but right now is hard to change without breaking everything.
roigcarlo
on 15 Oct 2018
Related issues
marcnunezc
路
5Comments
riccardotosi
路
5Comments
jcotela
路
4Comments
riccardotosi
路
7Comments
maceligueta
路
6Comments
Most helpful comment
Because travis runs the tests, and python files may very well affect tests passing/not passing.
There were some technical reasons why it was hard to detect if a PR affected only some files/file types (which is why travis always compiles, even if you just change python), but that does not change the main point.