Kops: Add spot label

[oded-dd]

1. Describe IN DETAIL the feature/behavior/change you would like to see.
I would like to be able to monitor the number of spot instances running inside the cluster without using the AWS SDK.

The way I expect to do it is by using kube-state-metrics which exposes the nodes labels.
Today I have no label indicating the node is a spot, while the information exists in AWS under node description lifecycle

2. Feel free to provide a design supporting your feature request.

[rifelpet]

Kops 1.17 automatically labels spot instances with node-role.kubernetes.io/spot-worker=true, are you using Kops 1.17?

[oded-dd]

@rifelpet Yes.

[johngmyers]

That feature was backed out of 1.17. It is in 1.18.

[hakman]

Should we add it back in? I think we rushed a bit with that revert.

[johngmyers]

The feature will go out with 1.18. I'm not so sure about backporting.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[olemarkus]

This one has been implemented, so we can close this now
/close

[k8s-ci-robot]

@olemarkus: Closing this issue.

In response to this:

This one has been implemented, so we can close this now
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.