Koin: [2.0.0-GA5] Named instances resolutions are broken

[renaudcerrato]

Just migrated from rc-2 to GA5, but I noticed that named definitions resolution is buggy. Root scope named definitions are hidden by un-named definitions in the current scope:

val fooModule = module {
  single(named("NAMED")) { Foo() }

  scope(named("MY_SCOPE")) {
     scoped { Foo() }
  }
} 

val barModule = module {
  // will get un-named Foo from scope instead of named Foo from root ! 
  single { Bar(get<Foo>(named("NAMED"))) }
}

getKoin().getOrCreateScope("scope_id", named( "MY_SCOPE")).get<Bar>()

The bug is located at Scope.findDefinition() since BeanRegistry.findDefinition() will return a definition matching the class (on the current scope !) if there's no named definition into that scope:

fun findDefinition(
            qualifier: Qualifier? = null,
            clazz: KClass<*>
    ): BeanDefinition<*>? =
            qualifier?.let { findDefinitionByName(it.toString()) }
                    ?: findDefinitionByClass(clazz)

[arnaudgiuliani]

Your scope is shadowing definitions from the global space, which is normal: when you define a scope and resolve from it, we are looking firstly from the scope definitions and then from the global scope.

Apart from that your case here is quite tricky ^^... as I wouldn't advise spreading scoped instances around to leak it?

[renaudcerrato]

Mmm... I'm asking for a named instance, and I'm ending up with an unnamed one! It was working perfectly on rc2. Could you read the issue carefully again?

If there's no definitions matching the qualifier on the current scope, we should look into the root scope before looking for a "class-only" definition.

[renaudcerrato]

The look-up for definitions should be : qualifier?.let { findByName(it) ?: root.findByName(it) } ?: findByClass(clazz) ?: root.findByClass(clazz)

[arnaudgiuliani]

yes I see

[arnaudgiuliani]

try with 2.0.0-GA6

[renaudcerrato]

Wow, that was fast! Will test that tomorrow, I'm AFK. Thanks 👍

[renaudcerrato]

GA6 fixed it! Thanks!