Koa: Remove Makefile, put everything in npm scripts
make is not available on Windows. NPM scripts however can run anywhere. Makefiles are also unnecessarily complicated for something simple as running mocha or eslint with a few options. Also, in npm scripts, you don't have to specify the path of the binary.
@stojanovic looking forward to your PR
felixfbecker
All 19 comments
I'm working on it ;)
targos
on 27 Oct 2015
Me too :)
Go for it, since I just stared :)
stojanovic
on 27 Oct 2015
targos
on 27 Oct 2015
how many of koajs committers/contributors use windows?
jonathanong
on 4 Mar 2016
Also, remember that cygwin/mingw, while somewhat of a pain, are still options, so it's not totally unworkable for Windows users.
PlasmaPower
on 4 Mar 2016
who's for and against this? my personal opinion: we should use npm scripts for wider compat, but not at the expense of having an unmanageable package.scripts object.
jonathanong
on 14 May 2016
I support Makefile because npm script is a fool choose for project. It only
support raw string, only.
2016-05-14 23:40 GMT+08:00 jongleberry [email protected]:
who's for and against this? my personal opinion: we should use npm scripts
for wider compat, but not at the expense of having an unmanageable
package.scripts object.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/koajs/koa/issues/559#issuecomment-219226923
alsotang
on 14 May 2016
I'm with jonathan, npm scripts unless they become unbearable.
fl0w
on 14 May 2016
Makefile is enough and npm scripts is not bad. But for universality, maybe npm scripts is more better:)
detailyang
on 24 May 2016
I vote npm scripts as well - they can get hairy, sure, but thats when you start breaking them out and chaining them instead.
jeffijoe
on 24 Jun 2016
Edit: Nevermind, we aren't doing that. They could work.
PlasmaPower
on 24 Jun 2016
I have compared a machine running Node that was started with NPM and one that was started in pure node command. The one started by npm start was using more memory and cpu just because NPM was "processing" the Node process itself. Since that day my Makefile calls node directly.
So, maybe, Makefile should be preserved and you guys should run a benchmark.
zanaca
on 5 Feb 2017
That's one reason I don't use npm scripts, the extra ~300ms bugs me, and it adds extra output. Not a huge deal, but if Windows was less of a mess it wouldn't be a problem :D, amazing that after all these years there's no make implementation. Cramming everything in a single string gets hard to read too.
tj
on 5 Feb 2017
@tj having just switched to Mac from Windows myself and I can confirm the mess that is Windows 😄
jeffijoe
on 5 Feb 2017
Do NOT replace Makefile by NPM scripts, the slow NPM scripts is not really good. How about adding scripts for Windows users?
dominhhai
on 6 Feb 2017
Yarn apparently solve npm scripts delay.
EduardoRFS
on 6 Feb 2017
npm start take some extra RAM and CPU cycles. Start your application, with load, and than run top in shell to see how many memory and CPU are being used.
zanaca
on 6 Feb 2017
With this simple of a task, we could also consider just writing a Node.JS script, then adding barebone .sh and .cmd wrappers around it.
PlasmaPower
on 6 Feb 2017
closed via #981
dead-horse
on 11 May 2017
Related issues
tracker1
·
3Comments
rainesinternationaldev
·
5Comments
xinshouke
·
4Comments
ilkkao
·
4Comments
koalex
·
3Comments
Most helpful comment
who's for and against this? my personal opinion: we should use npm scripts for wider compat, but not at the expense of having an unmanageable
package.scriptsobject.