Kiwix-android: Night Mode UI is not properly translated/translaable

Created on 26 Feb 2020  路  7Comments  路  Source: kiwix/kiwix-android

See the screenshot

image

It looks like "On", "Off", "Auto" are hardcoded string?

UI bug good first issue i18n question

All 7 comments

@kelson42 I would like to resolve this!

  <string-array name="pref_night_modes_entries">
    <item>On</item>
    <item>Off</item>
    <item>Auto</item>
  </string-array>

It hasn't been translated by TW, I can't remember if they handle string-arrays well

@macgills We want the "On", "Off" and "Auto" in their respective language once selected, not in English every time! Is this what we want to resolve in this ticket?

We want to add Arabic translations for the strings. Our translations are handled by Translatewiki, a lot of the process is automated so my concern was it was not picking up the string-array declaration.

We can fix this with a little layer of indirection if that is the case eg:

<string-array name="pref_night_modes_entries">
    <item>@string/on</item>
     .
     .
     .
  </string-array>

@yash982000 you may need to comment here before I can assign you

@macgills can I take up this issue?

@yashk2000 assigned. Please look to the previous PR for existing comments

Was this page helpful?
0 / 5 - 0 ratings

Related issues

brijeshshah13 picture brijeshshah13  路  4Comments

danielzgtg picture danielzgtg  路  4Comments

kelson42 picture kelson42  路  6Comments

asereze picture asereze  路  4Comments

Frans-Lukas picture Frans-Lukas  路  4Comments