Kiwix-android: Deprecated API Usage

[iadeelzafar]

Describe the bug
Deprecated API Usage in 2 files.

Expected behavior
Import updated classes and use it's methods.

Steps to reproduce the behavior:

1. Deprecated API Usage in KiwixDatabaseTest.Java and TestUtils.java.
2. androidTestImplementation of junit can be updated in build.gradle.
3. import updated class of AndroidJUnit and InstrumentationRegistry in KiwixdatabaseTest.Java.
4. import updated class of InstrumentationRegistry in TestUtils.Java.

[mhutti1]

We need to make sure testdroid supports this. Testdroid isn't run on fork prs so will need to be merged into a branch on origin then a new pr created so that the full test suite runs.

[iadeelzafar]

@mhutti1 Thanks for the response. Let me know if there's anything that I need to do. Id love to refine this and make it work.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

@mhutti1 @macgills Testdroid is not used anymore and the question of which farm of devices we should use is again fully open. Therefore, it seems to me we could close this issue?

[mhutti1]

I think it means we should implement the fixes?

[macgills]

Deprecated usages can be a bit annoying but it isn't the most urgent. We could raise the IDE inspection to error to heavily discourage deprecated usages happening in the future?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[amCap1712]

Is this still open for work?

[kelson42]

Is this still open for work?

@macgills ?

[macgills]

There are usages of deprecated apis.

The ticket does beg the question if we should finally get rid of things we have marked deprecated in our own codebase. This is mostly the old daos, removing them would mean user database data could no longer be migrated from pre 2.5 to latter versions, I think right now this would amount to 20,000 users so is probably still a no go even though cutting that library out would mean a reduced apk size/method count

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.