Kiwix-android: Show extended detail for a book in a bottom sheet

[mhutti1]

Feature Request

Allow users a way to open the parent folder of a ZIM file.
Probably using the same UI as #779

[renggli]

Turns out this is tricky to implement, as there is no standard way of opening a directory on Android. It can be made to work on certain devices, or if certain third-party apps are installed, but I see no generic way.

This is a similar bug of another android open-source project that describes the wider context of the problem: https://github.com/syncthing/syncthing-android/issues/838

[mhutti1]

Oh well, we can keep this open incase a solution is added in the future. Thanks for the work :)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

@mhutti1 Do we still really need that? I see no reason (anymore) so far.

[mhutti1]

I mean I think it does give them the flexibility to delete ZIM files themselves. Not sure if its technically possible though.

[kelson42]

@mhutti1 What I don't understand is "Allow users a way to open the parent folder of a ZIM file."

[mhutti1]

As in open the place the ZIM file is located in the file explorer app so they can see its context.

[kelson42]

@mhutti1 ZIM file should be deletable from the libary UI... but we don't need to open in a file browser. This is why I strongly suspect this feature request should/will not be implemented. Why making things complex if we can do it easily directly in the library?

[mhutti1]

Because I personally think that if we are saving very large files to a users phone we should at least give them an easy way to see exactly what we are doing.

[kelson42]

@mhutti1 What kind of information is actually missing to your opinion in Kiwix's library?

[mhutti1]

Where exactly the ZIM files are located.

[kelson42]

@mhutti1 We might be able to provide this information without having to implement that feature (just providing the path). I wonder if just saying if the ZIM file is on the "internal" or "external" storage might be enough?

[mhutti1]

Not really. Each device can do pretty much what they want, especially on older APIs. Making the path available would probably be ok though.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[macgills]

@mhutti1 Is this "For a BookOnDisk list item add an info icon to show extended detail on a book including path"?
We could use a modal bottom sheet and show that when a user clicks on the info icon, show as much information as possible and explicit open/delete(maybe share?) buttons. Would take some UI consideration.

[mhutti1]

That sounds like it could work.

[macgills]

@kelson42 should I create this BookDetailSheet? Bottom sheet examples here

[kelson42]

@macgills Yes please.

[macgills]

Here is a very rough implementation with not much formatting of the available data we have on a book

[macgills]

@kelson42 here is the current state of this sheet

shown on clicking this new (i) icon in the library

[macgills]

@kelson42 I think we should push this from 3.3 I want to make the release sooner rather than later and I think this will need some back and forth, also not a critical feature

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.