Kiwix-android: Bottom Toolbar hides the content of the last few lines on any page

Created on 3 Mar 2018 · 10Comments · Source: kiwix/kiwix-android

Bug Report

Are you ready to report?

Yes

Environment

version of the software you use : v2.3 Build 55
device / operating system : oneplus 3, Android 8.0

The Bug:

20180304_035223
The Bottom Toolbar when visible hides the last few lines of the webpage.

Steps to reproduce:

Enable Bottom Toolbar from the settings screen
Try scrolling down to last line

Expected Behavior: Either the webview should resize so that it is not covered by the Bottom Toolbar or the Bottom Toolbar should disappear when we reach at the end of the page.

I would like to work on this.

Please reviews @mhutti1 @kelson42 @brijeshshah13.

Source

RohanBh

All 10 comments

I am very worried about us simply going in circles with #555 and #556 and this possibly. These issues must be fixed synchronously not concurrently otherwise its very likely you will accidentally just undo each others work to get your issue fixed.

mhutti1 on 4 Mar 2018

I agree with you. I noticed this issue while working on this PR, since movement of bottom toolbar is constrained with that of action bar. So I opened this as soon as I completed that PR without realizing that similar issues have been opened.
Should I close this issue now?

RohanBh on 4 Mar 2018

Its up to you. Imo we should combine all issues relating to this into a single issue.

mhutti1 on 5 Mar 2018

👍1

@RohanBh @mhutti1 Agreed. There are multiple people working on this same task under different issues and PR's. Also, please note that we require a fix and not a hack.

brijeshshah13 on 5 Mar 2018

@brijeshshah13 What do you mean by a hack?

RohanBh on 5 Mar 2018

@RohanBh Like making the bottom toolbar transparent or as such.

brijeshshah13 on 5 Mar 2018

👍1

@mhutti1 How do we merge these issues? I can think of creating a main issue covering all the points in these sub-issues. Then reference the main issue from all these sub-issues and close them.
Or we can assign a person to work on all these issues and when he makes a PR, he'll just reference all these issues at once, thereby closing them as the PR is merged.

RohanBh on 5 Mar 2018

@RohanBh The first approach sounds better.

brijeshshah13 on 5 Mar 2018

👍1

Yeah we should do that. The person who created the first issue should get first attempt at solving the combined issue and the second next as such.

mhutti1 on 6 Mar 2018

👍1

I have fixed this in #832.