Kiwix-android: Language name overlapping with the number of files

Created on 28 Feb 2018  路  11Comments  路  Source: kiwix/kiwix-android

Is it a ?

  • [x] Bug Report

  • [ ] Feature Request

Bug Report

Step 1: Are you ready to report?

  • Your issue may already be reported! Please search on the issue track before creating one.
  • [x] I have tested with the last (dev) version of the software. ( If not, and if possible, run your test again with the most recent version available.)

Step 2: What is your environment?

  • version of the software you use : 2.3 Build: 55
  • device: Moto G4 plus

Step 3: Describe the problem:

When you open the dialog to select the language, the language name overlaps with the number of files.

Steps to reproduce:

screenshot_20180228-112200

  • What should be the behavior from your point of view? How do you expect the service to work?
    The text should resize so that no overlap takes place.

Are you willing to work on the issue?

    Yes.

@mhutti1 @kelson42 @brijeshshah13 @srv-twry Please review.

bug good first issue

Most helpful comment

We must not use ellipsize as the whole information is important. You can display name of the language in brackets in next line.

All 11 comments

Can I work on this issue?

@harshvardhan-takawale What is your proposed solution for this problem ?

@harsh-2711 It is already assigned. Please find another issue to work on.

@srv-twry I have thought of a few approaches. Please let me know which one to follow.
1) Ellipsize
2) Horizontally scrolling text
3) Autosizing textview (but that will only be effective with newer phones- API 26)

I would go for Ellipsize. Let's wait for other's suggestions.

Appologies, Accidently closed it.

We must not use ellipsize as the whole information is important. You can display name of the language in brackets in next line.

@harshvardhan-takawale @srv-twry I think the approach suggested by @abdulwd would be the best as the whole info matters. Still, wait until @mhutti1 reviews it.

Another vote for @abdulwd

@mhutti1 @brijeshshah13 @srv-twry @abdulwd @RajaVamsi11 I have one more idea. Can we shift the "localized name" below the "language name"?

@harshvardhan-takawale That's what I said. :)
If you want to do it for every item, it will increase the size of the list too much. So it would be better to show the localized name in next line if the text is long.

@abdulwd I'll have to think how to do that as it would require different layout file for some items only. Also, the size if the list won't increase even if we move all the localized names below as the height of the layout is already fixed as "?android:attr/listPreferredItemHeightSmall", it's just that the text will be a bit smaller for localized name .

Was this page helpful?
0 / 5 - 0 ratings