Kiwix-android: Text "use network to download content list." should be in the center of screen

Created on 15 Feb 2018  路  13Comments  路  Source: kiwix/kiwix-android

screenshot_20180214-222149

bug good first issue

All 13 comments

@parasg97 Thx for the bug report. You are right, please go ahead if you want to fix that bug.

Yes i would like to fix this

I would like to fix this bug

Currently, the margin of both textview and button is fixed to 230dp.I think it is not a good idea to keep margin fixed at a particular value. Also, there is no use of linear layout as its only child relative layout has dimensions match parent. Is it cool if I convert the layout to relative layout?
screenshot 30

@parasg97 make any changes you need to to refactor the layout. I think Android is moving to wards constraint layouts if you want to make use of them.

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@abdulwd @siddharth2010 May one you please just do a little fix to help quickly to fix that bug?

This button no longer exists. However I feel the "No content" text is not consistent across these 3 screens, in either positioning or size

I'd like to work on this issue, can I please go ahead and do that?

@CheshtaK please do. Just give our contributing guidelines a quick read first please, it might be best to click on them in the repo as opposed to following the links on the readme those are linking to slightly old copies right now but will be updated on the next release

how do I unsubscribe to this thread?

image
I assume you have similar options to myself @parasg97

@parasg97 , you can also unsubscribe from Gmail itself.

image

Was this page helpful?
0 / 5 - 0 ratings