Kiss: Can't add shortcuts to the launcher after the latest beta update

[praveenchandranpk]

I can't add any shortcuts to the launcher after the latest beta update. It was working fine before. I tried restarting the launcher and phone. Tried resetting shortcuts. Device is Oneplus5t android 9. All the previously added shortcuts are showing in the search results but can't add any new ones.

[hodanli]

same here. app shortcuts somehow disabled this feature. if i have to choose one, i choose the latter.

[Neamar]

Summoning @alenjularic into the discussion :)

[alenjularic]

I shall take a look at it tomorrow :)

[Neamar]

Thanks!

[alenjularic]

Hey @praveenchandranpk do you know what kind of shortcuts have you added dynamic, static? For what app did you add them? How did you previously add them?

[praveenchandranpk]

I added chrome web pages, whatsapp chats, some notebook pages from an app I use, Microsoft todo lists. They all have add to homescreen button in their settings. They all worked before. Now I tried all of them but none of them works.

[praveenchandranpk]

Sorry for being dumb. What's static and dynamic shortcuts? Can you give me an example?

[Neamar]

examples:

• from whatsapp, view a contact, then click on menu, more, add shortcut
• from Firefox, menu, page, add page shortcut.

It is indeed not working anymore

On Tue, Oct 8, 2019, 18:13 praveenchandranpk [e-mail]
wrote:

Sorry for being dumb. What's static and dynamic shortcuts? Can you give me
an example?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Neamar/KISS/issues/1275?email_source=notifications&email_token=AAEDCDGKHNUL3OGXT3PHK4LQNSWUFA5CNFSM4I6BG2L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAUXRYI#issuecomment-539588833,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEDCDFJVCD3ML7ALQXFNTTQNSWUFANCNFSM4I6BG2LQ
.

[alenjularic]

Ok guys, ty for all the feedback.
Somewhere in between development I removed the option to pin shortcuts... Sorry for the inconvenience.

A new PR is awaiting @Neamar with added support for pinned shortcuts 😃

[Neamar]

This should be fixed with 3.11.1.

If it isn't, ping me here and I'll reopen!

Thanks @alenjularic for the quick fix :)

[Neamar]

Hello! So I tried to add a shortcut from Firefox, and it doesn't seem to be working.

Pressing Menu => Page => add Page Shortcut does bring me back to the launcher, but no shortcut is actually created.

Logs do not show anything :(

@alenjularic sorry to bother you again, but do you think you can have another look at it? Sorry about that!

[alenjularic]

Hey @Neamar , I cant seem to reproduce it. I also use Firefox and can add shortcut without any problems.

I know it sounds silly, but are you on 3.11.1? Have you tried resetting shortcuts?

[Neamar]

Thanks! I looked into it, and I actually believe it was caused by https://github.com/Neamar/KISS/commit/bfbd2aae35fcac2de30136b7f898998212020486 :\ So my fault. Somehow, failing to inflate preferences.xml led to an issue with the shortcuts.

695ba086 fixed the issue. I'll close again, and test the app on a friend device to make sure it's fixed in the Play Store version too.

Sorry for the noise!