Kiss: Wrong Prefix automatically added to contact history

[MaxLux]

Recently called contacts get the german prefix added when called directly from KISS.

[MaxLux]

on KISS 2.27.0

[ntninja]

You to the phone number? Could you provide an example of this? The latest release contains a patch (from #480), that changed phone number handling quite a bit.

Thanks for help!

[HassanHeydariNasab]

Sometimes all of phone numbers starting by 0 (like 09123456789) converting to +44 (like [phone]).
There isn't any problem about phone numbers starting by +98 (my country code)
Thanks a lot!

[HassanHeydariNasab]

on KISS 2.27.0
:D

[MaxLux]

Hassan described the problem pretty well! In my case it were numbers with luxemburgish prefix. For example the Original Number would be 00352 621 * in KISS history it would appear as 0049352 621 or [phone] *. 00352 beeing the luxemburgish prefix. I have not encountered the problem with numbers saved with a + for the prefix. Opening the contacs app the numbers appear normal and sometimes even the history corrected. I will try to recreate the Problem some time but for the moment i downgraded to 2.25.

[StefanBrand]

I have the same issue. Numbers that start by "0" ("zero") instead have "+49" at the front. Example:
+49xxxxxxxxxx instead of 0xxxxxxxxxx.

Numbers that are stored with an existing number prefix (+43 in my case) don't suffer from this. They are still displayed correctly.

I'm going to downgrade.

PS.: This started in 2.27. I'm using a Fairphone 1 running Android Kitkat 4.4.2. the issue does not exist in 2.25.

[nmitsou]

I didn't manage to replicate this. I am on the v2.27.0 branch and added a phone number starting with a zero.
What are the steps I should do to see the +49 in front?

[HassanHeydariNasab]

You need some badluck!

[StefanBrand]

I can't reproduce this after downgrading and upgrading again. And the thing is that the issue appeared for me only yesterday. This leads me to two possibilities:

• the issue is triggered by some event
• the issue is time-dependent

I'm going to investigate further. I remember that yesterday, before the issue appeared, I synched my phone's contacts with my online storage (where I had entered some details to existing contacts, e.g. I added email addresses to a contact on my computer and synched them back to the phone via DAVdroid).

Am 25. November 2016 05:06:40 MEZ, schrieb nmitsou [e-mail]:

I didn't manage to replicate this. I am on the v2.27.0 branch and added
a phone number starting with a zero.
What are the steps I should do to see the +49 in front?

--
Diese Nachricht wurde von meinem Fairphone mit K-9 Mail gesendet.

[StefanBrand]

It happens to contacts stored on the SIM and in the DAVdroid account alike. However I still have the feeling that the issue is triggered by synchronization.

Another interesting observation: I noticed that a number in this format ( 0043xxxxxxxxxx) becomes +49043xxxxxxxxxx in KISS. So zeros get replaced no matter if it's already a country prefix or not.

I'm gonna downgrade again.

[Neamar]

Hey guys, thanks for the report.

Someone on the play store had a similar issue:

Pinging @alexander255 and @hamburger1984 again, since they probably know more about what's going on :)

[psykzz]

I also experienced this issue today.
Number came up with a UK prefix although it was an Irish number.

As a note though, I checked out @hamburger1984's issue-550 branch and tested it there, it did seem to fix the issue for me.

---

Before

---

After.

[Neamar]

Good then! Thanks for the report @psykzz I'll merge @hamburger1984 PR asap and publish again

[HassanHeydariNasab]

The problem not solved on 2.28.0

[Neamar]

I think the fix is in https://github.com/Neamar/KISS/releases/tag/v2.28.1

This version should already be in beta, see here https://plus.google.com/u/0/communities/116489528310489783081 :)

[StefanBrand]

Problem solved in 2.28.1, which I just updated from F-Droid. 👍

I don't understand, however, why numbers without a country prefix get one added in the first place. E.g. the number is stored as 0664 123 45 67 in the contacts app, but in KISS it is displayed as [phone]. Does KISS simply assume that all numbers without country prefix get one, depending on the country you are in at the moment? (E.g. would 0664 123 45 67 become [phone] when I am in Germany?)

[Neamar]

Yes, non-prefixed country automatically get a prefix depending on your sim card information.

For more information, you'll find the discussion related to this on https://github.com/Neamar/KISS/pull/484 :)

[HassanHeydariNasab]

in my case +44 is a wrong prefix. (instead of +98 in my country)
on 2.28.1