Kind: Error on extra/unknown on command line

Created on 29 Jan 2019  路  2Comments  路  Source: kubernetes-sigs/kind

I super-frequently (at least once a week) delete my default cluster "1" by running a command like kind delete cluster experiment-1548200336 without --name.

Right now it seems any extra command line terms are completely ignored, as in kind get kubeconfig-path foo bar baz

Recommend quality of life enhancement: Make presence of extra/unknown terms an error instead of letting them pass silently (and acting against default cluster "1").

kinbug prioritimportant-soon

Most helpful comment

unnamed args are a can of worms with Cobra...

this is the CLI i would definitely go for:

kind delete cluster --name=some-cluster # deletes the specified one
kind delete cluster # deletes the default one
kind delete cluster <unknown-arg> # throw error! no unnamed args or ordered args!!

All 2 comments

/kind bug
/assign
/priority important-soon

thanks for reporting! I'd totally forgotten about this, with recent enough cobra+pflag we should be able to set the number of positional args to handle this.

unnamed args are a can of worms with Cobra...

this is the CLI i would definitely go for:

kind delete cluster --name=some-cluster # deletes the specified one
kind delete cluster # deletes the default one
kind delete cluster <unknown-arg> # throw error! no unnamed args or ordered args!!
Was this page helpful?
0 / 5 - 0 ratings