Kibana: Enterprise search needs a11y tests

Created on 2 Oct 2020  路  4Comments  路  Source: elastic/kibana

Please add a11y tests to Enterprise search UI in Kibana - for overview page, app search and workplace search.
Here are the documents which explain a11y testing - https://www.elastic.co/guide/en/kibana/master/development-tests.html#development-accessibility-tests

Here is the meta issue where you can find other test PRs: https://github.com/elastic/kibana/issues/51456

Please get in touch with @myasonik or @bhavyarm if you have questions about these tests.

Accessibility AppSearch hours tests_needed

Most helpful comment

Awesome!! Thanks so much Michail. Accessibility requirements are definitely important to me personally, but as always it's a tough balancing act w/ our deadlines as well as figuring out what tooling makes the most sense long-term for running our functional/E2E tests. For what it's worth I'm trying to manually audit as much as code as I can accessibility-wise as we migrate it to Kibana.

I'll create a ticket in our migration epic for this and shoot to have the 3 pages listed above in Kibana CI by 7.11

All 4 comments

Pinging @elastic/app-search-frontend (Team:AppSearch)

Thanks @bhavyarm! We can definitely add accessibility tests for the following plugins/pages:

  • Overview plugin with all product cards showing
  • Setup Guide for both App Search & Workplace Search

... But unfortunately, I'm not sure we can (easily) add accessibility tests deeper into the products (which at the moment isn't a whole lot, so it's not a huge deal, but might be later on).

The problem is that our plugin requires Enterprise Search to run, and as far as we know (or were intending on implementing), Kibana's CI pipeline can't spin it up as a sidecar service.

I'm not too sure how in-depth these aXe reports/screenshots are compared to the E2E functional tests - if they're straightforward, it's possible we could somehow feed mock API endpoint data to the plugin, but that's still a pretty high lift for us right now when our focus is on fully migrating 2 products to Kibana by 8.0.

If basic a11y tests for just the above 3 pages (that don't require Enterprise Search to be configured/running) are OK for now, I can definitely look at implementing them, and circle back later after our full migration to more in-depth tests.

If basic a11y tests for just the above 3 pages (that don't require Enterprise Search to be configured/running) are OK for now, I can definitely look at implementing them, and circle back later after our full migration to more in-depth tests.

With the constraints you laid out, this sounds like a great place to start!

Awesome!! Thanks so much Michail. Accessibility requirements are definitely important to me personally, but as always it's a tough balancing act w/ our deadlines as well as figuring out what tooling makes the most sense long-term for running our functional/E2E tests. For what it's worth I'm trying to manually audit as much as code as I can accessibility-wise as we migrate it to Kibana.

I'll create a ticket in our migration epic for this and shoot to have the 3 pages listed above in Kibana CI by 7.11

Was this page helpful?
0 / 5 - 0 ratings